Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LFRic] User-defined DoF kernels should work with field vectors #2892

Closed
Tracked by #2744
TeranIvy opened this issue Feb 10, 2025 · 1 comment
Closed
Tracked by #2744

[LFRic] User-defined DoF kernels should work with field vectors #2892

TeranIvy opened this issue Feb 10, 2025 · 1 comment
Assignees
@TeranIvy @mo-alistairp
Labels
bug enhancement LFRic Issue relates to the LFRic domain

Comments

@TeranIvy
Copy link
Collaborator

Support for user-defined kernels that operate on DoFs is available in PSyclone 3.0.0. However, there is a limitation on them to not accept field vectors. That is an issues as a lot of PSyKAl-lite code that refers to this functionality uses coordinate fields which are field vectors.

Historically, this limitation may have arosen from inability of PSyclone built-ins to deal with field vectors, but it is not required for user-defined kernels in LFRic. This issue removes the limitation and adds the relevant code generation.
@TeranIvy TeranIvy added bug enhancement LFRic Issue relates to the LFRic domain labels Feb 10, 2025
@TeranIvy TeranIvy changed the title [LFRic] User-defined DoF kernels whould work with field vectors [LFRic] User-defined DoF kernels should work with field vectors Feb 10, 2025
mo-alistairp added a commit that referenced this issue Feb 13, 2025
@mo-alistairp
#2892 Remove limiting tests and ammend test cases
e0050b7
mo-alistairp added a commit that referenced this issue Feb 13, 2025
@mo-alistairp
#2892 Fix lint
52f286c
mo-alistairp added a commit that referenced this issue Feb 13, 2025
@mo-alistairp
#2892 Include field vector in test kernel
332656b
@TeranIvy TeranIvy mentioned this issue Feb 14, 2025
Closed
3 tasks
mo-alistairp added a commit that referenced this issue Feb 18, 2025
@mo-alistairp
#2892: Correct Fortran code
dde57f0
mo-alistairp added a commit that referenced this issue Feb 18, 2025
@mo-alistairp
#2892: Correct argument ordering
30c8e02
mo-alistairp added a commit that referenced this issue Feb 18, 2025
@mo-alistairp
#2892: Include code generation for field vectors on dofs
4d1d3fe
mo-alistairp added a commit that referenced this issue Feb 18, 2025
@mo-alistairp
#2892: Add authorship labels
9d66fa5
mo-alistairp added a commit that referenced this issue Feb 18, 2025
@mo-alistairp
#2892: Fix lint
34f9a77
mo-alistairp added a commit that referenced this issue Feb 19, 2025
@mo-alistairp
#2892: Add documentation of the DoF kernel changes
630773d
mo-alistairp added a commit that referenced this issue Feb 21, 2025
@mo-alistairp
#2892: Add TODO to fix after #1010
ddf9432
arporter added a commit that referenced this issue Feb 21, 2025
@arporter
Merge pull request #2897 from stfc/2892_support_user_defined_dof_kern…
f7bce31 
…els_field_vector

#2892 Allow user-defined DoF kernels to act on field vectors
@arporter
Copy link
Member

#2897 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeranIvy TeranIvy

@mo-alistairp mo-alistairp

Labels
bug enhancement LFRic Issue relates to the LFRic domain
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arporter @TeranIvy @mo-alistairp