@@ -81,7 +81,7 @@ function test_determine_next_misuse_current_and_next_are_reviewed()
8181 $ this ->createConclusiveReviewState ($ misuse2 );
8282
8383 // current misuse = 1, reviewer = 1
84- list ($ previous_misuse , $ next_misuse , $ next_reviewable_misuse , $ misuse ) = $ this ->reviewController ->determineNavigationTargets ($ runs , Experiment::find (2 ), '-p- ' , '-v- ' , $ misuse1 ->misuse_muid , $ this ->reviewer1 , 30 );
84+ list ($ previous_misuse , $ next_misuse , $ next_reviewable_misuse , $ misuse ) = $ this ->reviewControllerHelper -> reviewController ->determineNavigationTargets ($ runs , Experiment::find (2 ), '-p- ' , '-v- ' , $ misuse1 ->misuse_muid , $ this ->reviewer1 , 30 );
8585
8686 self ::assertEquals ($ misuse3 ->misuse_muid , $ previous_misuse ->misuse_muid );
8787 self ::assertEquals ($ misuse2 ->misuse_muid , $ next_misuse ->misuse_muid );
@@ -99,7 +99,7 @@ function test_determine_next_misuse_current_is_only_reviewable()
9999 $ this ->createConclusiveReviewState ($ misuse2 );
100100
101101 // current misuse = 3, reviewer = 1
102- list ($ previous_misuse , $ next_misuse , $ next_reviewable_misuse , $ misuse ) = $ this ->reviewController ->determineNavigationTargets ($ runs , Experiment::find (2 ), '-p- ' , '-v- ' , $ misuse3 ->misuse_muid , $ this ->reviewer1 , 30 );
102+ list ($ previous_misuse , $ next_misuse , $ next_reviewable_misuse , $ misuse ) = $ this ->reviewControllerHelper -> reviewController ->determineNavigationTargets ($ runs , Experiment::find (2 ), '-p- ' , '-v- ' , $ misuse3 ->misuse_muid , $ this ->reviewer1 , 30 );
103103
104104 self ::assertEquals ($ misuse2 ->misuse_muid , $ previous_misuse ->misuse_muid );
105105 self ::assertEquals ($ misuse1 ->misuse_muid , $ next_misuse ->misuse_muid );
@@ -118,7 +118,7 @@ function test_determine_next_misuse_not_fully_reviewed()
118118 $ this ->reviewControllerHelper ->createReview ($ misuse3 , $ this ->reviewer2 , "Yes " );
119119
120120 // current misuse = 1, reviewer = 1
121- list ($ previous_misuse , $ next_misuse , $ next_reviewable_misuse , $ misuse ) = $ this ->reviewController ->determineNavigationTargets ($ runs , Experiment::find (2 ), '-p- ' , '-v- ' , $ misuse1 ->misuse_muid , $ this ->reviewer1 , 30 );
121+ list ($ previous_misuse , $ next_misuse , $ next_reviewable_misuse , $ misuse ) = $ this ->reviewControllerHelper -> reviewController ->determineNavigationTargets ($ runs , Experiment::find (2 ), '-p- ' , '-v- ' , $ misuse1 ->misuse_muid , $ this ->reviewer1 , 30 );
122122
123123 self ::assertEquals ($ misuse3 ->misuse_muid , $ previous_misuse ->misuse_muid );
124124 self ::assertEquals ($ misuse2 ->misuse_muid , $ next_misuse ->misuse_muid );
@@ -136,7 +136,7 @@ function test_determine_nav_multiple_runs()
136136 $ this ->createConclusiveReviewState ($ misuse1 );
137137
138138 // current misuse = 2, reviewer = 1
139- list ($ previous_misuse , $ next_misuse , $ next_reviewable_misuse , $ misuse ) = $ this ->reviewController ->determineNavigationTargets ($ runs , Experiment::find (2 ), '-p1- ' , '-v- ' , $ misuse2 ->misuse_muid , $ this ->reviewer1 , 30 );
139+ list ($ previous_misuse , $ next_misuse , $ next_reviewable_misuse , $ misuse ) = $ this ->reviewControllerHelper -> reviewController ->determineNavigationTargets ($ runs , Experiment::find (2 ), '-p1- ' , '-v- ' , $ misuse2 ->misuse_muid , $ this ->reviewer1 , 30 );
140140
141141 self ::assertEquals ($ misuse1 ->misuse_muid , $ previous_misuse ->misuse_muid );
142142 self ::assertEquals ($ misuse1 ->misuse_muid , $ next_misuse ->misuse_muid );
0 commit comments