Skip to content

Commit 8348c76

Browse files
committed
Fix navigation outside of the review size.
1 parent 9f5c2fd commit 8348c76

1 file changed

Lines changed: 16 additions & 2 deletions

File tree

mubench.reviewsite/src/Controllers/ReviewsController.php

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,24 @@ public function getReview(Request $request, Response $response, array $args)
4141

4242
$runs = RunsController::getRuns($detector, $experiment, $ex2_review_size);
4343

44-
$all_misuses = $this->collectAllMisuses($runs);
44+
$limited_all_misuses = $this->collectAllMisuses($runs);
4545

4646
list($previous_misuse, $next_misuse, $next_reviewable_misuse, $misuse) =
47-
$this->determineNavigationTargets($all_misuses, $project_muid, $version_muid, $misuse_muid, $reviewer);
47+
$this->determineNavigationTargets($limited_all_misuses, $project_muid, $version_muid, $misuse_muid, $reviewer);
48+
49+
if(!$misuse){
50+
$runs = Run::of($detector)->in($experiment)->orderBy('project_muid')->orderBy('version_muid')->get();
51+
52+
$all_misuses = $this->collectAllMisuses($runs);
53+
54+
list($previous_misuse, $next_misuse, $next_reviewable_misuse, $misuse) =
55+
$this->determineNavigationTargets($all_misuses, $project_muid, $version_muid, $misuse_muid, $reviewer);
56+
57+
$next_misuse = $all_misuses->first();
58+
if($limited_all_misuses->where('id', $next_reviewable_misuse->id)->isEmpty()){
59+
$next_reviewable_misuse = null;
60+
}
61+
}
4862

4963
$all_violations = Violation::all();
5064
$all_tags = Tag::all()->sortBy('name');

0 commit comments

Comments
 (0)