style: 💄 fix linter issues

Author: streamich

biome.json

@@ -45,7 +45,8 @@
 				"useOptionalChain": "off",
 				"noCommaOperator": "off",
 				"noUselessLabel": "off",
-				"noBannedTypes": "off"
+				"noBannedTypes": "off",
+				"noUselessUndefinedInitialization": "off"
 			},
 			"security": {
 				"noGlobalEval": "off"

packages/json-joy/src/json-crdt-extensions/cnt/__demos__/usage.ts

@@ -6,7 +6,7 @@
  *     npx nodemon -q -x ts-node src/json-crdt-extensions/cnt/__demos__/usage.ts
  */
 
-import {Model, s} from '../../../json-crdt';
+import {Model} from '../../../json-crdt';
 import {cnt} from '..';
 
 console.clear();

packages/json-joy/src/json-crdt-extensions/peritext/editor/__tests__/Editor-merge.spec.ts

@@ -1,4 +1,4 @@
-import {type Kit, runAlphabetKitTestSuite, setupAlphabetKit, setupKit} from '../../__tests__/setup';
+import {type Kit, setupAlphabetKit, setupKit} from '../../__tests__/setup';
 import {CommonSliceType} from '../../slice';
 import {SliceTypeCon} from '../../slice/constants';
 import * as fixtures from './fixtures';

packages/json-joy/src/json-crdt-extensions/peritext/editor/__tests__/merge.ts

@@ -1,23 +1,23 @@
 import type {ViewRange} from '../types';
-import {logTree, toTree} from 'pojo-dump';
+// import {logTree, toTree} from 'pojo-dump';
 import {ModelWithExt, ext} from '../../../ModelWithExt';
 import type {PeritextNode} from '../../PeritextNode';
 import type {Model} from '../../../../json-crdt/model';
 import type {ExtensionNode} from '../../../../json-crdt/schema/types';
 
-const normalizeViewRange = (view: ViewRange): void => {
-  const [, offset, slices] = view;
-  const length = slices.length;
-  if (offset > 0) {
-    view[1] = 0;
-    for (let i = 0; i < length; i++) {
-      const slice = slices[i];
-      slice[1] += offset;
-      slice[2] += offset;
-    }
-  }
-  slices.sort((a, b) => a[1] - b[1] || a[2] - b[2] || 1);
-};
+// const normalizeViewRange = (view: ViewRange): void => {
+//   const [, offset, slices] = view;
+//   const length = slices.length;
+//   if (offset > 0) {
+//     view[1] = 0;
+//     for (let i = 0; i < length; i++) {
+//       const slice = slices[i];
+//       slice[1] += offset;
+//       slice[2] += offset;
+//     }
+//   }
+//   slices.sort((a, b) => a[1] - b[1] || a[2] - b[2] || 1);
+// };
 
 export const assertCanMergeInto = (model: Model<ExtensionNode<PeritextNode>>, view: ViewRange): void => {
   // logTree(view);
@@ -46,7 +46,6 @@ export const assertCanMergeIntoEmptyDocument = (view: ViewRange): void => {
 
 export const assertCanMergeViewTrain = (views: ViewRange[]): void => {
   const model = ModelWithExt.create(ext.peritext.new(''), 1234567890123);
-  const i = 1;
   for (const view of views) {
     // console.log(`Merging view ${i++} of ${views.length}`);
     assertCanMergeInto(model, view);

packages/json-joy/src/json-crdt-extensions/peritext/events/__tests__/cursor.spec.ts

@@ -373,7 +373,7 @@ const testSuite = (getKit: () => Kit) => {
     describe('collapses selection into the direction of movement', () => {
       test('when focus is at end of selection', () => {
         const kit = setup();
-        const view = kit.editor.text();
+        const _view = kit.editor.text();
         kit.et.cursor({at: [10, 10 + 10]});
         kit.et.cursor({move: [['focus', 'char', 0, true]]});
         expect(kit.editor.cursor.start.viewPos()).toBe(20);
@@ -386,7 +386,7 @@ const testSuite = (getKit: () => Kit) => {
 
       test('when focus is at the start of the selection', () => {
         const kit = setup();
-        const view = kit.editor.text();
+        const _view = kit.editor.text();
         kit.et.cursor({at: [20, 20 - 10]});
         kit.et.cursor({move: [['end', 'char', 0, true]]});
         expect(kit.editor.cursor.start.viewPos()).toBe(20);

packages/json-joy/src/json-crdt-extensions/peritext/events/defaults/PeritextEventDefaults.ts

@@ -424,34 +424,34 @@ export class PeritextEventDefaults implements PeritextEventHandlerMap {
             range.collapseToStart();
             const start = range.start;
             const pos = start.viewPos();
-            let inserted: number = 0;
+            let _inserted: number = 0;
             switch (format) {
               case 'html': {
-                inserted = transfer.fromHtml(pos, text);
+                _inserted = transfer.fromHtml(pos, text);
                 break;
               }
               case 'hast': {
                 const json = JSON.parse(text);
-                inserted = transfer.fromHast(pos, json);
+                _inserted = transfer.fromHast(pos, json);
                 break;
               }
               case 'jsonml': {
                 const json = JSON.parse(text);
-                inserted = transfer.fromJson(pos, json);
+                _inserted = transfer.fromJson(pos, json);
                 break;
               }
               case 'json': {
                 const json = JSON.parse(text);
-                inserted = transfer.fromView(pos, json);
+                _inserted = transfer.fromView(pos, json);
                 break;
               }
               case 'mdast': {
                 const json = JSON.parse(text);
-                inserted = transfer.fromMdast(pos, json);
+                _inserted = transfer.fromMdast(pos, json);
                 break;
               }
               case 'md': {
-                inserted = transfer.fromMarkdown(pos, text);
+                _inserted = transfer.fromMarkdown(pos, text);
                 break;
               }
             }

packages/json-joy/src/json-crdt-extensions/peritext/overlay/Overlay.ts

@@ -5,7 +5,6 @@ import {first2, insert2, last2, next2, prev2, remove2} from 'sonic-forest/lib/ut
 import {splay} from 'sonic-forest/lib/splay/util';
 import {Anchor} from '../rga/constants';
 import {OverlayPoint} from './OverlayPoint';
-import {OverlayRefSliceEnd, OverlayRefSliceStart} from './refs';
 import {compare, type ITimestampStruct} from '../../../json-crdt-patch/clock';
 import {CONST, updateNum} from '../../../json-hash/hash';
 import {Slice} from '../slice/Slice';
@@ -611,28 +610,24 @@ export class Overlay<T = string> implements Printable, Stateful {
           });
         }
         if (savedSlicesChanged || extraSlicesChanged) {
-          // biome-ignore lint: .forEach() is the way to iterate here.
           savedSlices.forEach((slice) => {
             if (slice.isMarker()) this.upsertSlice(slice);
             else this.upsertSlice(slice);
           });
-          // biome-ignore lint: .forEach() is the way to iterate here.
           extraSlices.forEach((slice) => {
             if (slice.isMarker()) this.upsertSlice(slice);
             else this.upsertSlice(slice);
           });
         }
         if (localSlicesChanged || savedSlicesChanged || extraSlicesChanged) {
           const sliceSet = this.slices;
-          // biome-ignore lint: .forEach() is the way to iterate here.
           localSlices.forEach((slice) => {
             const tuple = sliceSet.get(slice);
             if (tuple) {
               const positionMoved = tuple[0].cmp(slice.start) !== 0 || tuple[1].cmp(slice.end) !== 0;
               if (positionMoved) this.delSlice(slice, tuple);
             }
           });
-          // biome-ignore lint: .forEach() is the way to iterate here.
           localSlices.forEach((slice) => {
             const tuple = slice.isMarker() ? this.upsertSlice(slice) : this.upsertSlice(slice);
             this.slices.set(slice, tuple);

packages/json-joy/src/json-crdt-extensions/peritext/slice/Slices.ts

@@ -170,7 +170,6 @@ export class Slices<T = string> implements Stateful, Printable {
   }
 
   public forEach(callback: (item: Slice<T>) => void): void {
-    // biome-ignore lint: list is not iterable
     this.list.forEach((node) => callback(node.v));
   }
 
@@ -184,19 +183,16 @@ export class Slices<T = string> implements Stateful, Printable {
     if (topologyHash !== this._topologyHash) {
       this._topologyHash = topologyHash;
       let chunk: ArrChunk | undefined;
-      let order = 0;
       for (const iterator = this.set.iterator(); (chunk = iterator()); ) {
         const item = this.list.get(chunk.id);
         if (chunk.del) {
           if (item) this.list.del(chunk.id);
         } else {
           if (!item) this.list.set(chunk.id, this.unpack(this.set, chunk));
-          order++;
         }
       }
     }
     let hash: number = topologyHash;
-    // biome-ignore lint: slices is not iterable
     this.list.forEach(({v: item}) => {
       item.refresh();
       hash = updateNum(hash, item.hash);