Skip to content

Clickhouse and reorg handling #96

@YaroShkvorets

Description

@YaroShkvorets

Versions prior to 4.6 required non-zero value for --undo-buffer-size flag which made sense as we essentially want a buffer to handle reorgs in memory before flushing into Clickhouse.

But now it fails to start unless it's set to zero, which doesn't seem to make sense. Otherwise if you specify non-zero value you get this contradicting error:

2025-06-19T14:36:28.414-0400 ERRO (sink-sql) creating loader: driver &{%!s(*clickhouse.Options=<nil>) <nil> %!s(func() error=<nil>) %!s(func(string, ...interface {})=0x103f749e0)} does not support reorg handling. You must use set a non-zero undo-buffer-size

It appears current version has this line:

handleReorgs := sflags.MustGetInt(cmd, "undo-buffer-size") != 0

Prior versions had it the other way:

handleReorgs := sflags.MustGetInt(cmd, "undo-buffer-size") == 0

Typo?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions