Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve]: optimize the controller reconcile #223

Open
ericsyh opened this issue Jul 26, 2024 · 2 comments · Fixed by #225
Open

[improve]: optimize the controller reconcile #223

ericsyh opened this issue Jul 26, 2024 · 2 comments · Fixed by #225
Assignees

Comments

@ericsyh
Copy link
Member

ericsyh commented Jul 26, 2024

Background

Now the resource operator uses a single controller for all resources CR, and the reconcile now is executed sequentially. If one resource is illegal the reconcile will be interrupted and impact the following resource update.

How to improve

Ideally we should separate controller for each resource CR and make sure each one has a separate reconcile as the #69 wanna do. But it may take longer time to do the refactor, so we can have a quick way to optimize: we can udpate the controller error handlding and don't stop the reconcile even some resources updating were failed. Then the resource update won't be missed or stopped even some Pulsar admin API call fails.

@ericsyh ericsyh changed the title [improve]: optimize the controller recouncile [improve]: optimize the controller reconcile Jul 26, 2024
@freeznet
Copy link
Member

freeznet commented Aug 31, 2024

reopen this because #225 only solves the topic resource, but not other type of resources.

@freeznet freeznet reopened this Aug 31, 2024
@freeznet
Copy link
Member

db49be7 fixes the namespace reconclie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants