perf: Optimize MSBuild project loading and dependency handling #2932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced caching for MSBuild project loading to improve performance and prevent redundant loads. Added mechanisms to avoid infinite recursion during dependency processing and ensured sequential handling of project references to address MSBuild limitations. Refactored package upgrade logic to simplify checks and reuse cached projects for NuGet reference updates. Enhanced error handling with detailed logging for unexpected exceptions. Added cleanup methods to unload and dispose of cached projects, ensuring proper resource management. Improved handling of NuGet restores and platform updates by re-evaluating project properties post-restore. Updated dependency processing to ensure all assemblies are registered and dependencies are loaded recursively. Finalized with proper state updates for packages and session-wide cleanup of cached projects.
Contributor
Author
|
I tested it with some projects that included required Stride dependency updates, and it worked fine. |
Collaborator
|
msbuild gets opened twice mybe the overall process may be simplified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Introduced caching for MSBuild project loading to improve performance and prevent redundant loads. Added mechanisms to avoid infinite recursion during dependency processing and ensured sequential handling of project references to address MSBuild limitations.
Refactored package upgrade logic to simplify checks and reuse cached projects for NuGet reference updates. Enhanced error handling with detailed logging for unexpected exceptions.
Added cleanup methods to unload and dispose of cached projects, ensuring proper resource management. Improved handling of NuGet restores and platform updates by re-evaluating project properties post-restore.
Updated dependency processing to ensure all assemblies are registered and dependencies are loaded recursively. Finalized with proper state updates for packages and session-wide cleanup of cached projects.
In my setup with 26 projects the time to restore the NuGet packages was reduced from ~60 seconds to ~30 seconds.
Related Issue
No issue created yet.
Types of changes
Checklist