Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Clean Solution to Diffing Hierarchies #63

Closed
bplunkett-stripe opened this issue Aug 29, 2023 · 1 comment
Closed

Find Clean Solution to Diffing Hierarchies #63

bplunkett-stripe opened this issue Aug 29, 2023 · 1 comment

Comments

@bplunkett-stripe
Copy link
Collaborator

Diffing hierarchies like indexes is pretty gross right now. If the parent index is re-created, we need to push that re-create down to the child indexes. There's no good way of doing this, so we're forced to use a hackaround where when diffing the child indexes we:

  1. Use the old and new schema map to fetch the old and new parent
  2. Diff the old and new parent to figure out if we need to re-create them
@bplunkett-stripe
Copy link
Collaborator Author

Closing in favor of #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant