Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse unix timestamps into times (time.Time) #1205

Open
msingleton opened this issue Oct 11, 2020 · 2 comments
Open

Parse unix timestamps into times (time.Time) #1205

msingleton opened this issue Oct 11, 2020 · 2 comments
Labels

Comments

@msingleton
Copy link

It'd be nice to parse timestamps into their time.Time during unmarshaling. I'd expect most people will be operating with the values as times (could be wrong) so most people are having to do time.Unix(invoice.PeriodEnd, 0)

Obviously not a big deal, but nice to have!

@richardm-stripe
Copy link
Contributor

Hi @msingleton. I think this makes sense, and we have analogs in other libraries. We have plans to codegen this library in the not-too-distant future which would make a change like this a lot easier to do, so we will punt on this for now but possibly revisit after that lands.

@msingleton
Copy link
Author

👍 sounds great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants