Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] SPM Improvement #2842

Open
ryang1428 opened this issue Aug 9, 2023 · 2 comments
Open

[Feature] SPM Improvement #2842

ryang1428 opened this issue Aug 9, 2023 · 2 comments
Labels
kind:improvement triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@ryang1428
Copy link

Is your feature request related to a problem? Please describe.

  • When bringing in the SDK via Swift Package Manager, in the current setup when downloading the Stripe package, it also needs to compile the code. This increases compile time, which for us is important as we pay for build minutes for our CI (via Git Actions).

Describe the solution you'd like

  • Provide a swift package that references binary targets of xcframeworks
    • Here's an example of another SDK we use which does this

Describe alternatives you've considered

  • We currently cannot leverage SPM and import the SDK using the xcframework, which just increases the effort to keep the SDK updated. Going this route also muddies up our commit history, we've seen some updates contain over 1m changes (most of which are JSON files we found).

Thanks!

@davidme-stripe
Copy link
Contributor

davidme-stripe commented Aug 9, 2023

Hi @ryang1428, thanks for filing this! We'll consider adding a binary SPM distribution — Xcode's support for binary Swift frameworks was unreliable in the past, but it has improved in recent versions. For now, here are a few other ideas:

@ryang1428
Copy link
Author

@davidme-stripe Thanks for the quick response-- and that would be great! We did see the stripe-ios-spm repo, but 30 seconds (even 10s) adds to to be a lot of CI minutes for us for the amount of builds we run. We'll continue to bring in the xcframework directly

@davidme-stripe davidme-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:improvement triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

No branches or pull requests

2 participants