You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
This issue has gone the other direction of most, coming out of #1168, where there was discussion about the implementation and the underlying intent/goal.
When instrumenting Stripe through an APM tool (like DataDog), it would be great to have something available within instrumentation event payloads that represents the Stripe "concept" and action being interacted with.
Describe the solution you'd like
As an example, when creating a customer, having object: customer, action: create would be ideal. There is already method, which is the HTTP method, so that might be good enough for the action, however, there really isn't an equivalent for the "concept".
path might sometimes work (POST /customers), but when updating a customer, seeing PATCH /customers/cus_123 as the higher-level interaction does not provide the value within APM as something like customer.update, which groups updates across customers.
Describe alternatives you've considered
No response
Additional context
DataDog's dd-trace-rb gem now has Stripe integration (DataDog/dd-trace-rb#2557), which includes tags for the path and method, but there isn't a great value to use as the resource.
For comparison, instrumenting the AWS SDK results in values like s3.list_buckets, s3.get_object, etc.
I hope this is helpful context!
The text was updated successfully, but these errors were encountered:
Hi. I chatted with the team an we think this feature makes sense in the context of distributed tracing.
With the library changes that I mentioned in the linked PR coming we'd like to take a bit more time to design distributed tracing in a way that's consistent between all seven libraries.
Try with including a new field in the instrumentation event payloads called "concept" which represents the high-level concept being interacted with (e.g., customer, payment). For each action, include a corresponding value (e.g., create, update). This will provide a clear representation of the Stripe concept and action within APM tools like DataDog.
Is your feature request related to a problem? Please describe.
This issue has gone the other direction of most, coming out of #1168, where there was discussion about the implementation and the underlying intent/goal.
When instrumenting Stripe through an APM tool (like DataDog), it would be great to have something available within instrumentation event payloads that represents the Stripe "concept" and action being interacted with.
Describe the solution you'd like
As an example, when creating a customer, having
object: customer, action: create
would be ideal. There is alreadymethod
, which is the HTTP method, so that might be good enough for theaction
, however, there really isn't an equivalent for the "concept".path
might sometimes work (POST /customers
), but when updating a customer, seeingPATCH /customers/cus_123
as the higher-level interaction does not provide the value within APM as something likecustomer.update
, which groups updates across customers.Describe alternatives you've considered
No response
Additional context
DataDog's dd-trace-rb gem now has Stripe integration (DataDog/dd-trace-rb#2557), which includes tags for the path and method, but there isn't a great value to use as the
resource
.For comparison, instrumenting the AWS SDK results in values like
s3.list_buckets
,s3.get_object
, etc.I hope this is helpful context!
The text was updated successfully, but these errors were encountered: