Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility issues #1491

Closed
saritaSchen opened this issue Nov 20, 2024 · 3 comments
Closed

Fix accessibility issues #1491

saritaSchen opened this issue Nov 20, 2024 · 3 comments

Comments

@saritaSchen
Copy link

saritaSchen commented Nov 20, 2024

While fixing some accessibility issues on my companies website, I stumbled over two issues.

One comes from the Stripe element with the class __PrivateStripeElement-input:

ARIA hidden element must not be focusable or contain focusable elements

The other one from an <iframe> tag with the name __privateStripeFrame7343

Frames with focusable content must not have tabindex=-1

Solutions

To solve the first issue, the focusable content should be disabled or be removed from the DOM. There is no reason to use an aria-hidden attribute on a focusable element. -> explanation

For the second issue, the tab-index needs to be changed to not be negative. -> explanation

Additional context

The first issue was mentioned here as well but the thread was closed without it being solved.

For my company it would be crucial that is is solved because according to the European Accessibility Act, websites will legally be required to have a certain level of accessibility until end of June 2025, which includes fixing these issues.

@saritaSchen saritaSchen changed the title Fix accessibility issue: aria-hidden input fields are focusable Fix accessibility issues Nov 20, 2024
@jar-stripe
Copy link
Contributor

Hi @saritaSchen , thanks for the report. This is the repository for the backend Stripe SDK for Ruby; did you mean to post this in the react-stripe-js repository?

@saritaSchen
Copy link
Author

Apologies @jar-stripe, to be honest, I wasn't sure where to post this. Thanks for the pointer!

@jar-stripe
Copy link
Contributor

No apologies needed! We're always happy to help where we can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants