Skip to content

Commit 6291193

Browse files
committed
chore(isthmus): minor refactoring of SimpleExtensionToSqlOperator
1 parent ec45173 commit 6291193

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

isthmus/src/main/java/io/substrait/isthmus/SimpleExtensionToSqlOperator.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ public final class SimpleExtensionToSqlOperator {
2828
private static final RelDataTypeFactory DEFAULT_TYPE_FACTORY =
2929
new JavaTypeFactoryImpl(SubstraitTypeSystem.TYPE_SYSTEM);
3030

31+
private static final CalciteTypeVisitor CALCITE_TYPE_VISITOR = new CalciteTypeVisitor();
32+
3133
private SimpleExtensionToSqlOperator() {}
3234

3335
public static List<SqlOperator> from(SimpleExtension.ExtensionCollection collection) {
@@ -60,7 +62,7 @@ private static SqlFunction toSqlFunction(
6062
for (SimpleExtension.Argument arg : function.requiredArguments()) {
6163
if (arg instanceof SimpleExtension.ValueArgument) {
6264
SimpleExtension.ValueArgument valueArg = (SimpleExtension.ValueArgument) arg;
63-
SqlTypeName typeName = valueArg.value().accept(new CalciteTypeVisitor());
65+
SqlTypeName typeName = valueArg.value().accept(CALCITE_TYPE_VISITOR);
6466
argFamilies.add(typeName.getFamily());
6567
} else if (arg instanceof SimpleExtension.EnumArgument) {
6668
// Treat an EnumArgument as a required string literal.

0 commit comments

Comments
 (0)