fix: lint

Author: psteinroe

crates/pglt_analyser/tests/rules_tests.rs

@@ -23,7 +23,7 @@ fn rule_test(full_path: &'static str, _: &str, _: &str) {
     };
 
     let query =
-        read_to_string(full_path).expect(format!("Failed to read file: {} ", full_path).as_str());
+        read_to_string(full_path).unwrap_or_else(|_| panic!("Failed to read file: {} ", full_path));
 
     let ast = pglt_query_ext::parse(&query).expect("failed to parse SQL");
     let options = AnalyserOptions::default();
@@ -51,7 +51,6 @@ fn rule_test(full_path: &'static str, _: &str, _: &str) {
 fn parse_test_path(path: &Path) -> (String, String, String) {
     let mut comps: Vec<&str> = path
         .components()
-        .into_iter()
         .map(|c| c.as_os_str().to_str().unwrap())
         .collect();
 
@@ -97,13 +96,10 @@ impl Expectation {
     }
 
     fn assert(&self, diagnostics: &[RuleDiagnostic]) {
-        match self {
-            Self::NoDiagnostics => {
-                if !diagnostics.is_empty() {
-                    panic!("This test should not have any diagnostics.");
-                }
+        if let Self::NoDiagnostics = self {
+            if !diagnostics.is_empty() {
+                panic!("This test should not have any diagnostics.");
             }
-            _ => {}
         }
     }
 }

crates/pglt_test_macros/src/lib.rs

@@ -227,7 +227,7 @@ impl TryFrom<PathBuf> for Variables {
         Ok(Variables {
             test_name: test_name.into(),
             test_fullpath: test_fullpath.into(),
-            test_expected_fullpath: test_expected_fullpath.into(),
+            test_expected_fullpath,
             test_dir: test_dir.into(),
         })
     }

xtask/codegen/src/generate_new_analyser_rule.rs

@@ -73,7 +73,7 @@ impl Rule for {rule_name_upper_camel} {{
     )
 }
 
-static EXAMPLE_SQL: &'static str = r#"
+static EXAMPLE_SQL: &str = r#"
     -- select 1;
 "#;