Merge pull request #885 from supabase/close-both-apps

fix: Close both apps to allow for process restart
supabase · Feb 5, 2025 · fc69684 · fc69684
2 parents 8ad7e24 + 38e265d
commit fc69684
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/server/admin-app.ts b/src/server/admin-app.ts
@@ -1,11 +1,9 @@
 import { fastify, FastifyInstance, FastifyServerOptions } from 'fastify'
-
-import FastifyMetrics from 'fastify-metrics'
+import fastifyMetrics from 'fastify-metrics'
 
 export function build(opts: FastifyServerOptions = {}): FastifyInstance {
   const app = fastify(opts)
-  // @ts-ignore fastify-metrics doesn't work with NodeNext resolution
-  app.register(FastifyMetrics, {
+  app.register(fastifyMetrics.default, {
     endpoint: '/metrics',
     routeMetrics: { enabled: false },
   })

diff --git a/src/server/server.ts b/src/server/server.ts
@@ -158,9 +158,15 @@ if (EXPORT_DOCS) {
       app.log.error(err)
     }
     await app.close()
+    await adminApp.close()
   })
   app.addHook('onClose', async () => {
     closeListeners.uninstall()
+    await adminApp.close()
+  })
+  adminApp.addHook('onClose', async () => {
+    closeListeners.uninstall()
+    await app.close()
   })
 
   app.listen({ port: PG_META_PORT, host: PG_META_HOST }, (err) => {