Bug: TypeScript type inference allows null for !inner join results in supabase-js v2.48.1

[rhslvkf]

Bug report

• I confirm this is a bug with Supabase, not with my own application.
• I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

In supabase-js v2.48.1, when using the !inner keyword for inner joins, the TypeScript type inference incorrectly includes null in the return type. This is logically incorrect since inner joins by definition cannot return null values. This regression was introduced in v2.48.1, as it worked correctly in v2.47.5.

To Reproduce

Steps to reproduce the behavior:

1. Install supabase-js v2.48.1

npm install @supabase/[email protected]

2. Create a query with an inner join:

const result = await supabase
  .from('table1')
  .select('field!inner(table2)')

// TypeScript infers result type as { field: object | null }
// This is incorrect as inner join cannot return null

3. Compare with v2.47.5 where the type is correctly inferred without null

Expected behavior

When using !inner for joins, the TypeScript type system should not include null in the return type, as inner joins by definition cannot return null values.

System information

• Version of supabase-js: 2.48.1
• Version of Node.js: Latest LTS

Additional context

The issue appears to be related to type definition changes between v2.47.5 and v2.48.1. In v2.47.5, the type definition correctly handled inner joins with the inner: true property, while v2.48.1 changed this to innerJoin: true and added additional type checks that incorrectly allow for null values.

Previous working implementation (v2.47.5):

[{ name: Name; original: Name; children: Fields; inner: true }, EatWhitespace<Remainder>]

Current implementation with issue (v2.48.1):

[{ type: 'field'; name: Name; innerJoin: true; children: Children }, Remainder]

This appears to be an unintended side effect of the type system changes in v2.48.1.