Code cleaning #4359
Open
Code cleaning #4359
+197,408
−197,291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t if there's none. supermerill/SuperSlicer/issues#778
Owner
|
I'm okay with removing warnings. |
supermerill
reviewed
Jul 9, 2024
Owner
supermerill
left a comment
supermerill
left a comment
There was a problem hiding this comment.
too many changes that will makes merging harder. Please ask that in prusaslicer first.
Author
|
ok, I understand the issue when merging from Prusa. I'll prepare a cleaner pull request for the elimination of warnings. |
|
I work on the OrcaSlicer project and I would LOVE to do this to Orca as well. Biggest issue is merging between the projects. Maybe we can get all of the Slic3r projects to agree on a clang-format standard and we could format all of the projects? In a perfect world :) |
supermerill
force-pushed
the
nightly_dev
branch
4 times, most recently
from
5e0f604 to
787415d
Compare
supermerill
force-pushed
the
nightly_dev
branch
from
787415d to
5dc2ae8
Compare
supermerill
force-pushed
the
nightly_dev
branch
7 times, most recently
from
6919ee2 to
97361d8
Compare
supermerill
force-pushed
the
nightly_dev
branch
6 times, most recently
from
3502a2d to
d0d86fb
Compare
supermerill
force-pushed
the
nightly_dev
branch
from
c8bc91f to
197b958
Compare
supermerill
force-pushed
the
nightly_dev
branch
3 times, most recently
from
9666afb to
d2805c5
Compare
supermerill
force-pushed
the
nightly_dev
branch
4 times, most recently
from
83945d3 to
6a38e57
Compare
supermerill
force-pushed
the
nightly_dev
branch
from
6a38e57 to
2edd82f
Compare
supermerill
force-pushed
the
nightly_dev
branch
4 times, most recently
from
d7411c5 to
6464dc0
Compare
supermerill
force-pushed
the
nightly_dev
branch
2 times, most recently
from
3dbdd38 to
df104cd
Compare
supermerill
force-pushed
the
nightly_dev
branch
from
6f66612 to
beaa1bf
Compare
supermerill
force-pushed
the
nightly_dev
branch
from
eeaa4ad to
7f41751
Compare
supermerill
force-pushed
the
nightly_dev
branch
5 times, most recently
from
fe5af4c to
e5004df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits eliminate a lot of warnings while compiling (unused variables and functions, indenation, improper types). Inaddition there is one commit that does some cosmetics: remove trailing blanks and replaces tabs with 4 spaces.