Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect ReSwift source path in Cartfile #2

Closed
ichina opened this issue Apr 21, 2018 · 5 comments
Closed

incorrect ReSwift source path in Cartfile #2

ichina opened this issue Apr 21, 2018 · 5 comments

Comments

@ichina
Copy link

ichina commented Apr 21, 2018

u need to fix source path for ReSwift
from
github "ReactiveX/ReSwift" ~> 4.0
to
github "ReSwift/ReSwift"

@svdo
Copy link
Owner

svdo commented Apr 21, 2018

My reasoning for doing it the way I did: both Carthage and CocoaPods use semantic versioning. Specifying version ~> 4.0 means: any version 4.x.x, in other words: 4.0.0 or higher, but less than 5.0.0. This is on purpose, because by definition version 5.x.x will have API breaking changes compared to version 4.x.x. So I only want to allow major version 4, otherwise everything may break as soon as ReSwift releases version 5.0.0. Makes sense?

I assume you're making this change because of a problem you're running into. If you can describe the problem, I'll try to help you find a solution.

@ichina
Copy link
Author

ichina commented Apr 21, 2018

amm, i mean you have wrong vendor name here in ReSwift lib, not ReactiveX, but ReSwift.
everything is ok with semantic versioning

@ichina
Copy link
Author

ichina commented Apr 21, 2018

this problem is exercised when trying to install ReRxSwift through Carthage

@svdo
Copy link
Owner

svdo commented Apr 21, 2018

Ah I see now, sorry about that. I want to keep the version number, so I'll just change it myself instead of using your pull request. Thanks for reporting this!

@ichina
Copy link
Author

ichina commented Apr 21, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants