-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: Throw on unrendered snippets in dev
#15766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Throw on unrendered snippets in dev
#15766
Conversation
🦋 Changeset detectedLatest commit: b7b6991 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Wait wasn't #15521 fixing this? |
Oh no just looked at the code right now and it's a different situation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good apart from the error message
Co-authored-by: Simon H <[email protected]>
Co-authored-by: Simon H <[email protected]>
e079ac9
into
main
Currently, if you try to render a snippet without
@render
, Svelte will not complain -- it'll just stringify the snippet to the DOM. That's pretty annoying. During dev, we'll now throw an error reminding you to render your snippets.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint