Skip to content

fix: Throw on unrendered snippets in dev #15766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

Currently, if you try to render a snippet without @render, Svelte will not complain -- it'll just stringify the snippet to the DOM. That's pretty annoying. During dev, we'll now throw an error reminding you to render your snippets.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 15, 2025

🦋 Changeset detected

Latest commit: b7b6991

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15766

@svelte-docs-bot
Copy link

@paoloricciuti
Copy link
Member

Wait wasn't #15521 fixing this?

@paoloricciuti
Copy link
Member

Oh no just looked at the code right now and it's a different situation

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good apart from the error message

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github merged commit e079ac9 into main Apr 16, 2025
13 checks passed
@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github deleted the elliott/throw-on-unrendered-snippets branch April 16, 2025 01:58
@github-actions github-actions bot mentioned this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants