Skip to content

#each not removing old rows from DOM if it contains await #17851

@phi-bre

Description

@phi-bre

Describe the bug

When spamming the Spam button in the playground reproduction (so updating the state before the promise is resolved), it will lead to existing rows not being removed.

In 5.53.6 it works fine for a flat $state('string') variable and failed with Cannot read properties of undefined (reading 'e') when the state variable is a nested object $state({id: 'object'}).

Now, in 5.53.7 it will fail for both flat or nested state variables.

The (reading 'e') error was fixed in #17843 and merged in 5.53.7, but I'm more leaning towards #17819 having something to do with it.

Reproduction

Playground with $state('string') and 5.53.7
Playground with $state('string') and 5.53.6

Playground with $state({id: 'object'}) and 5.53.7
Playground with $state({id: 'object'}) and 5.53.6

Logs

System Info

playground

Severity

annoyance

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions