Repository navigation
handoff discarded fork runs to a surviving batch - #19278
Draft
Rich-Harris wants to merge 2 commits into
Draft
Rich-Harris wants to merge 2 commits into
Rich-Harris wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/2173053b0977bc3713139d9792e40544b8ff0ad5Open in |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addendum to #19277 that handles various edge cases around discarded/failed forks. I asked an agent to look for these tricky cases and attempt to solve them, and this is what it wrote. I don't love it — it's a lot of new code, and it's not uncomplicated — so I'm looking into whether there are simpler (if less optimal in certain edge cases) approaches.
The tl;dr of the diff below is that @dummdidumm was right in #19262 about needing to switch batches mid-run, an idea that still gives me the heebie-jeebies