Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weirdness with REPL GitHub auth #368

Open
Conduitry opened this issue Oct 20, 2018 · 3 comments
Open

Weirdness with REPL GitHub auth #368

Conduitry opened this issue Oct 20, 2018 · 3 comments

Comments

@Conduitry
Copy link
Member

I just clicked on a link to a Gist ( https://svelte.technology/repl?version=2.14.0&gist=1283275c377670446b7a96308c831436 ) created by someone else, and the UI seems to indicate that I am logged in as them. I don't know yet whether this is a UI thing or an actual problem with auth.

I'm going to try playing around with this, using a gist created by me so I'm not potentially mucking with someone else's data.

@Conduitry
Copy link
Member Author

Okay I just signed in as myself and back out and it's not happening for me - nor is it happening anymore on the REPL link in the above post. So that's leading me to believe that it probably is some sort of genuine auth issue. I'll have to play with this locally (with a separate oauth app) to track this down.

@Conduitry
Copy link
Member Author

I really don't know what was happening before. I haven't been able to reproduce it locally either...

@Conduitry
Copy link
Member Author

From chat - It seems likely this is a Cloudflare thing. We should try to see whether Cloudflare respects cache-control: private on the origin server response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant