Add response duration tracking to webhook message attempts (#1877)

Author: CodeMan62

Diff for: server/openapi.json

@@ -1520,7 +1520,7 @@
                         "type": "string"
                     },
                     "responseDurationMs": {
-                        "description": "Response duration in milliseconds.\n\nCurrently, this is not actually recorded in the OSS version of Svix, so this field always has a value of `0`.",
+                        "description": "Response duration in milliseconds.",
                         "format": "int64",
                         "type": "integer"
                     },
@@ -1706,7 +1706,7 @@
                         "type": "string"
                     },
                     "responseDurationMs": {
-                        "description": "Response duration in milliseconds.\n\nCurrently, this is not actually recorded in the OSS version of Svix, so this field always has a value of `0`.",
+                        "description": "Response duration in milliseconds.",
                         "format": "int64",
                         "type": "integer"
                     },

Diff for: server/svix-server/migrations/20240906000000_add_response_duration.down.sql

@@ -0,0 +1,2 @@
+-- Remove response_duration_ms column from messageattempt table
+ALTER TABLE messageattempt DROP COLUMN response_duration_ms;

Diff for: server/svix-server/migrations/20240906000000_add_response_duration.up.sql

@@ -0,0 +1,2 @@
+-- Add response_duration_ms column to messageattempt table
+ALTER TABLE messageattempt ADD COLUMN response_duration_ms BIGINT NOT NULL DEFAULT 0;

Diff for: server/svix-server/src/db/models/messageattempt.rs

@@ -25,6 +25,8 @@ pub struct Model {
     pub response: String,
     pub ended_at: Option<DateTimeWithTimeZone>,
     pub trigger_type: MessageAttemptTriggerType,
+    /// Response duration in milliseconds
+    pub response_duration_ms: i64,
 }
 
 #[derive(Copy, Clone, Debug, EnumIter, DeriveRelation)]

Diff for: server/svix-server/src/v1/endpoints/attempt.rs

@@ -66,9 +66,6 @@ pub struct MessageAttemptOut {
     #[schemars(example = "example_status_code")]
     pub response_status_code: i16,
     /// Response duration in milliseconds.
-    ///
-    /// Currently, this is not actually recorded in the OSS version of Svix, so
-    /// this field always has a value of `0`.
     pub response_duration_ms: i64,
     pub status: MessageStatus,
     pub trigger_type: MessageAttemptTriggerType,
@@ -88,7 +85,7 @@ impl From<messageattempt::Model> for MessageAttemptOut {
             url: model.url,
             response: model.response,
             response_status_code: model.response_status_code,
-            response_duration_ms: 0,
+            response_duration_ms: model.response_duration_ms,
             status: model.status,
             trigger_type: model.trigger_type,
             msg_id: model.msg_id,

Diff for: server/svix-server/src/worker.rs

@@ -352,11 +352,15 @@ async fn make_http_call(
         url: Set(endp.url.clone()),
         ended_at: Set(Some(Utc::now().into())),
         trigger_type: Set(msg_task.trigger_type),
+        response_duration_ms: Set(0), // Default to 0, will be updated after the request
         ..Default::default()
     };
 
     match client.execute(req).await {
         Ok(res) => {
+            // Calculate the duration in milliseconds
+            let duration_ms = (Utc::now() - created_at).num_milliseconds();
+
             let status_code = res.status().as_u16() as i16;
             let status = if res.status().is_success() {
                 MessageStatus::Success
@@ -386,6 +390,7 @@ async fn make_http_call(
                 response_status_code: Set(status_code),
                 response: Set(body),
                 status: Set(status),
+                response_duration_ms: Set(duration_ms),
                 ..attempt
             };
 
@@ -397,15 +402,21 @@ async fn make_http_call(
                 None => Ok(CompletedDispatch::Successful(SuccessfulDispatch(attempt))),
             }
         }
-        Err(err) => Ok(CompletedDispatch::Failed(FailedDispatch(
-            messageattempt::ActiveModel {
-                response_status_code: Set(0),
-                response: Set(err.to_string()),
-                status: Set(MessageStatus::Fail),
-                ..attempt
-            },
-            err.into(),
-        ))),
+        Err(err) => {
+            // For errors, we still calculate the duration
+            let duration_ms = (Utc::now() - created_at).num_milliseconds();
+
+            Ok(CompletedDispatch::Failed(FailedDispatch(
+                messageattempt::ActiveModel {
+                    response_status_code: Set(0),
+                    response: Set(err.to_string()),
+                    status: Set(MessageStatus::Fail),
+                    response_duration_ms: Set(duration_ms),
+                    ..attempt
+                },
+                err.into(),
+            )))
+        }
     }
 }