[stdlib] Admit defeat & replace @_transparent with @inline(__always)

Author: lorentey

stdlib/public/core/ClosedRange.swift

@@ -128,7 +128,8 @@ extension ClosedRange: RangeExpression {
   /// - Parameter element: The element to check for containment.
   /// - Returns: `true` if `element` is contained in the range; otherwise,
   ///   `false`.
-  @_transparent
+  @inlinable
+  @inline(__always)
   public func contains(_ element: Bound) -> Bool {
     return element >= self.lowerBound && element <= self.upperBound
   }
@@ -383,7 +384,7 @@ extension ClosedRange {
   ///
   /// - Complexity: O(1)
   @_alwaysEmitIntoClient
-  @_transparent
+  @inline(__always)
   public func contains(_ other: ClosedRange<Bound>) -> Bool {
     lowerBound <= other.lowerBound && upperBound >= other.upperBound
   }

stdlib/public/core/Range.swift

@@ -195,7 +195,8 @@ public struct Range<Bound: Comparable> {
   /// - Parameter element: The element to check for containment.
   /// - Returns: `true` if `element` is contained in the range; otherwise,
   ///   `false`.
-  @_transparent
+  @inlinable
+  @inline(__always)
   public func contains(_ element: Bound) -> Bool {
     return lowerBound <= element && element < upperBound
   }
@@ -683,7 +684,8 @@ extension PartialRangeFrom: RangeExpression {
   ) -> Range<Bound> where C.Index == Bound {
     return self.lowerBound..<collection.endIndex
   }
-  @_transparent
+  @inlinable
+  @inline(__always)
   public func contains(_ element: Bound) -> Bool {
     return lowerBound <= element
   }
@@ -1075,12 +1077,12 @@ extension Range {
   ///
   /// - Complexity: O(1)
   @_alwaysEmitIntoClient
-  @_transparent
+  @inline(__always)
   public func contains(_ other: Range<Bound>) -> Bool {
     other.isEmpty ||
       (lowerBound <= other.lowerBound && upperBound >= other.upperBound)
   }
-  
+
   /// Returns a Boolean value indicating whether the given closed range is
   /// contained within this range.
   ///
@@ -1103,7 +1105,7 @@ extension Range {
   ///
   /// - Complexity: O(1)
   @_alwaysEmitIntoClient
-  @_transparent
+  @inline(__always)
   public func contains(_ other: ClosedRange<Bound>) -> Bool {
     lowerBound <= other.lowerBound && upperBound > other.upperBound
   }

test/stdlib/RangeContainsInlining.swift

@@ -10,20 +10,20 @@
 // The sample functions below use bounds of different integer types to avoid
 // them tail-calling each other.
 
-// CHECK-LABEL: define {{.*}} i1 @"$s21RangeContainsInlining08halfOpenB0ySbSnys4Int8VG_ADtF"
-// CHECK-NOT: call swiftcc
-// CHECK: icmp
-// CHECK-NOT: call swiftcc
-// CHECK-LABEL: {{^}}}
+// CHECK-OPTIMIZED-LABEL: define {{.*}} i1 @"$s21RangeContainsInlining08halfOpenB0ySbSnys4Int8VG_ADtF"
+// CHECK-OPTIMIZED-NOT: call swiftcc
+// CHECK-OPTIMIZED: icmp
+// CHECK-OPTIMIZED-NOT: call swiftcc
+// CHECK-OPTIMIZED-LABEL: {{^}}}
 public func halfOpenContains(_ r: Range<Int8>, _ i: Int8) -> Bool {
   r.contains(i)
 }
 
 // CHECK-LABEL: define  {{.*}} i1 @"$s21RangeContainsInlining06closedB0ySbSNys5Int16VG_ADtF"
-// CHECK-NOT: call swiftcc
-// CHECK: icmp
-// CHECK-NOT: call swiftcc
-// CHECK-LABEL: {{^}}}
+// CHECK-OPTIMIZED-NOT: call swiftcc
+// CHECK-OPTIMIZED: icmp
+// CHECK-OPTIMIZED-NOT: call swiftcc
+// CHECK-OPTIMIZED-LABEL: {{^}}}
 public func closedContains(_ r: ClosedRange<Int16>, _ i: Int16) -> Bool {
   r.contains(i)
 }