BridgeJS: Align naming for stack based types from "raise" to "lift"

Author: krodak

Benchmarks/Sources/Generated/BridgeJS.swift

@@ -279,7 +279,7 @@ extension SimpleStruct: _BridgedSwiftStruct {
     func toJSObject() -> JSObject {
         let __bjs_self = self
         __bjs_self.bridgeJSLowerReturn()
-        return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_SimpleStruct()))
+        return JSObject(id: UInt32(bitPattern: _bjs_struct_lift_SimpleStruct()))
     }
 }
 
@@ -293,10 +293,10 @@ fileprivate func _bjs_struct_lower_SimpleStruct(_ objectId: Int32) -> Int32 {
 #endif
 
 #if arch(wasm32)
-@_extern(wasm, module: "bjs", name: "swift_js_struct_raise_SimpleStruct")
-fileprivate func _bjs_struct_raise_SimpleStruct() -> Int32
+@_extern(wasm, module: "bjs", name: "swift_js_struct_lift_SimpleStruct")
+fileprivate func _bjs_struct_lift_SimpleStruct() -> Int32
 #else
-fileprivate func _bjs_struct_raise_SimpleStruct() -> Int32 {
+fileprivate func _bjs_struct_lift_SimpleStruct() -> Int32 {
     fatalError("Only available on WebAssembly")
 }
 #endif
@@ -332,7 +332,7 @@ extension Address: _BridgedSwiftStruct {
     func toJSObject() -> JSObject {
         let __bjs_self = self
         __bjs_self.bridgeJSLowerReturn()
-        return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Address()))
+        return JSObject(id: UInt32(bitPattern: _bjs_struct_lift_Address()))
     }
 }
 
@@ -346,10 +346,10 @@ fileprivate func _bjs_struct_lower_Address(_ objectId: Int32) -> Int32 {
 #endif
 
 #if arch(wasm32)
-@_extern(wasm, module: "bjs", name: "swift_js_struct_raise_Address")
-fileprivate func _bjs_struct_raise_Address() -> Int32
+@_extern(wasm, module: "bjs", name: "swift_js_struct_lift_Address")
+fileprivate func _bjs_struct_lift_Address() -> Int32
 #else
-fileprivate func _bjs_struct_raise_Address() -> Int32 {
+fileprivate func _bjs_struct_lift_Address() -> Int32 {
     fatalError("Only available on WebAssembly")
 }
 #endif
@@ -391,7 +391,7 @@ extension Person: _BridgedSwiftStruct {
     func toJSObject() -> JSObject {
         let __bjs_self = self
         __bjs_self.bridgeJSLowerReturn()
-        return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_Person()))
+        return JSObject(id: UInt32(bitPattern: _bjs_struct_lift_Person()))
     }
 }
 
@@ -405,10 +405,10 @@ fileprivate func _bjs_struct_lower_Person(_ objectId: Int32) -> Int32 {
 #endif
 
 #if arch(wasm32)
-@_extern(wasm, module: "bjs", name: "swift_js_struct_raise_Person")
-fileprivate func _bjs_struct_raise_Person() -> Int32
+@_extern(wasm, module: "bjs", name: "swift_js_struct_lift_Person")
+fileprivate func _bjs_struct_lift_Person() -> Int32
 #else
-fileprivate func _bjs_struct_raise_Person() -> Int32 {
+fileprivate func _bjs_struct_lift_Person() -> Int32 {
     fatalError("Only available on WebAssembly")
 }
 #endif
@@ -453,7 +453,7 @@ extension ComplexStruct: _BridgedSwiftStruct {
     func toJSObject() -> JSObject {
         let __bjs_self = self
         __bjs_self.bridgeJSLowerReturn()
-        return JSObject(id: UInt32(bitPattern: _bjs_struct_raise_ComplexStruct()))
+        return JSObject(id: UInt32(bitPattern: _bjs_struct_lift_ComplexStruct()))
     }
 }
 
@@ -467,10 +467,10 @@ fileprivate func _bjs_struct_lower_ComplexStruct(_ objectId: Int32) -> Int32 {
 #endif
 
 #if arch(wasm32)
-@_extern(wasm, module: "bjs", name: "swift_js_struct_raise_ComplexStruct")
-fileprivate func _bjs_struct_raise_ComplexStruct() -> Int32
+@_extern(wasm, module: "bjs", name: "swift_js_struct_lift_ComplexStruct")
+fileprivate func _bjs_struct_lift_ComplexStruct() -> Int32
 #else
-fileprivate func _bjs_struct_raise_ComplexStruct() -> Int32 {
+fileprivate func _bjs_struct_lift_ComplexStruct() -> Int32 {
     fatalError("Only available on WebAssembly")
 }
 #endif

Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift

@@ -1184,9 +1184,9 @@ struct StructCodegen {
         let accessControl = structDef.explicitAccessControl.map { "\($0) " } ?? ""
 
         let lowerExternName = "swift_js_struct_lower_\(structDef.name)"
-        let raiseExternName = "swift_js_struct_raise_\(structDef.name)"
+        let liftExternName = "swift_js_struct_lift_\(structDef.name)"
         let lowerFunctionName = "_bjs_struct_lower_\(structDef.name)"
-        let raiseFunctionName = "_bjs_struct_raise_\(structDef.name)"
+        let liftFunctionName = "_bjs_struct_lift_\(structDef.name)"
 
         let bridgedStructExtension: DeclSyntax = """
             extension \(raw: typeName): _BridgedSwiftStruct {
@@ -1207,7 +1207,7 @@ struct StructCodegen {
                 \(raw: accessControl)func toJSObject() -> JSObject {
                     let __bjs_self = self
                     __bjs_self.bridgeJSLowerReturn()
-                    return JSObject(id: UInt32(bitPattern: \(raw: raiseFunctionName)()))
+                    return JSObject(id: UInt32(bitPattern: \(raw: liftFunctionName)()))
                 }
             }
             """
@@ -1220,16 +1220,16 @@ struct StructCodegen {
                 returnType: .i32
             )
         )
-        let raiseExternDecl = Self.renderStructExtern(
-            externName: raiseExternName,
-            functionName: raiseFunctionName,
+        let liftExternDecl = Self.renderStructExtern(
+            externName: liftExternName,
+            functionName: liftFunctionName,
             signature: SwiftSignatureBuilder.buildABIFunctionSignature(
                 abiParameters: [],
                 returnType: .i32
             )
         )
 
-        return [bridgedStructExtension, lowerExternDecl, raiseExternDecl]
+        return [bridgedStructExtension, lowerExternDecl, liftExternDecl]
     }
 
     private static func renderStructExtern(

Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift

@@ -475,10 +475,10 @@ public struct BridgeJSLink {
                         }
                         printer.write("}")
 
-                        printer.write("bjs[\"swift_js_struct_raise_\(structDef.name)\"] = function() {")
+                        printer.write("bjs[\"swift_js_struct_lift_\(structDef.name)\"] = function() {")
                         printer.indent {
                             printer.write(
-                                "const value = \(JSGlueVariableScope.reservedStructHelpers).\(structDef.name).raise(\(JSGlueVariableScope.reservedTmpRetStrings), \(JSGlueVariableScope.reservedTmpRetInts), \(JSGlueVariableScope.reservedTmpRetF32s), \(JSGlueVariableScope.reservedTmpRetF64s), \(JSGlueVariableScope.reservedTmpRetPointers));"
+                                "const value = \(JSGlueVariableScope.reservedStructHelpers).\(structDef.name).lift(\(JSGlueVariableScope.reservedTmpRetStrings), \(JSGlueVariableScope.reservedTmpRetInts), \(JSGlueVariableScope.reservedTmpRetF32s), \(JSGlueVariableScope.reservedTmpRetF64s), \(JSGlueVariableScope.reservedTmpRetPointers));"
                             )
                             printer.write("return \(JSGlueVariableScope.reservedSwift).memory.retain(value);")
                         }