Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add usd fee values #133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add usd fee values #133

wants to merge 2 commits into from

Conversation

tcar121293
Copy link
Contributor

Add usd fee values

Description

Added usd value to fees

Related Issue Or Context

Closes: #103

How Has This Been Tested? Testing details.

e2e tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmlinaric nmlinaric nmlinaric approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@wainola wainola Awaiting requested review from wainola

@MakMuftic MakMuftic Awaiting requested review from MakMuftic

@mj52951 mj52951 Awaiting requested review from mj52951

Assignees
No one assigned
Labels
Do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add usd conversion to fee
4 participants
@tcar121293 @mpetrun5 @nmlinaric @MakMuftic