Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed context on failure #113

Open
2 tasks
MakMuftic opened this issue Oct 2, 2023 · 0 comments
Open
2 tasks

More detailed context on failure #113

MakMuftic opened this issue Oct 2, 2023 · 0 comments

Comments

@MakMuftic
Copy link
Contributor

Story

As a user
I want to understand the reason why my transaction failed on execution
So that I can feel like my assets are safe

As a on-duty developer
I want to quickly understand the reason why transaction failed on execution
So that I can take appropriate actions

Background

We had a few incidents on PHA routes, where users had locked their founds for smaller periods as liquidity was missing on the destination chain. This on Explorer is displayed as generic failed transaction, where it would be a much better user experience if we showed the actual reason why this happened.

Details

This piece of art is a rough sketch of how something like this could look.

index_liq_change_1

index_liq_change_2

We are providing additional context on failed transactions. We could possibly even use this to automate retries based on fail context in the future.

Implementation details

We should start with something simple, such as only recognizing the situation where there is missing liquidity on the destination chain. Still, we should design a solution that can be extendable to hold different failed contexts.

Testing details

  • Add unit tests
  • Test on devnet/testnet

Acceptance criteria

  • Indexer API expanded to save and provide information on failure context
  • Explorer UI displays additional context for failed transactions
@MakMuftic MakMuftic added this to the Cycle 3 milestone Oct 20, 2023
@MakMuftic MakMuftic removed this from the Cycle 3+4 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant