Use CPP where possible

Author: alexandre-daubois

Definition/NumericNode.php

@@ -20,14 +20,14 @@
  */
 class NumericNode extends ScalarNode
 {
-    protected int|float|null $min;
-    protected int|float|null $max;
-
-    public function __construct(?string $name, ?NodeInterface $parent = null, int|float|null $min = null, int|float|null $max = null, string $pathSeparator = BaseNode::DEFAULT_PATH_SEPARATOR)
-    {
+    public function __construct(
+        ?string $name,
+        ?NodeInterface $parent = null,
+        protected int|float|null $min = null,
+        protected int|float|null $max = null,
+        string $pathSeparator = BaseNode::DEFAULT_PATH_SEPARATOR,
+    ) {
         parent::__construct($name, $parent, $pathSeparator);
-        $this->min = $min;
-        $this->max = $max;
     }
 
     protected function finalizeValue(mixed $value): mixed

Exception/FileLocatorFileNotFoundException.php

@@ -18,13 +18,13 @@
  */
 class FileLocatorFileNotFoundException extends \InvalidArgumentException
 {
-    private array $paths;
-
-    public function __construct(string $message = '', int $code = 0, ?\Throwable $previous = null, array $paths = [])
-    {
+    public function __construct(
+        string $message = '',
+        int $code = 0,
+        ?\Throwable $previous = null,
+        private array $paths = [],
+    ) {
         parent::__construct($message, $code, $previous);
-
-        $this->paths = $paths;
     }
 
     public function getPaths(): array

Loader/FileLoader.php

@@ -27,13 +27,12 @@ abstract class FileLoader extends Loader
 {
     protected static array $loading = [];
 
-    protected FileLocatorInterface $locator;
-
     private ?string $currentDir = null;
 
-    public function __construct(FileLocatorInterface $locator, ?string $env = null)
-    {
-        $this->locator = $locator;
+    public function __construct(
+        protected FileLocatorInterface $locator,
+        ?string $env = null,
+    ) {
         parent::__construct($env);
     }
 

Resource/ReflectionClassResource.php

@@ -23,14 +23,14 @@ class ReflectionClassResource implements SelfCheckingResourceInterface
 {
     private array $files = [];
     private string $className;
-    private \ReflectionClass $classReflector;
     private array $excludedVendors = [];
     private string $hash;
 
-    public function __construct(\ReflectionClass $classReflector, array $excludedVendors = [])
-    {
+    public function __construct(
+        private \ReflectionClass $classReflector,
+        array $excludedVendors = [],
+    ) {
         $this->className = $classReflector->name;
-        $this->classReflector = $classReflector;
         $this->excludedVendors = $excludedVendors;
     }