Skip to content

Commit 0b93f32

Browse files
committed
do not let context classes extend the message classes
1 parent 0f2afc8 commit 0b93f32

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Messenger/RunProcessContext.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,16 @@
1616
/**
1717
* @author Kevin Bond <[email protected]>
1818
*/
19-
final class RunProcessContext extends RunProcessMessage
19+
final class RunProcessContext
2020
{
2121
public readonly ?int $exitCode;
2222
public readonly ?string $output;
2323
public readonly ?string $errorOutput;
2424

25-
public function __construct(RunProcessMessage $message, Process $process)
26-
{
27-
parent::__construct($message->command, $message->cwd, $message->env, $message->input, $message->timeout);
28-
25+
public function __construct(
26+
public readonly RunProcessMessage $message,
27+
Process $process,
28+
) {
2929
$this->exitCode = $process->getExitCode();
3030
$this->output = $process->isOutputDisabled() ? null : $process->getOutput();
3131
$this->errorOutput = $process->isOutputDisabled() ? null : $process->getErrorOutput();

Tests/Messenger/RunProcessMessageHandlerTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public function testRunSuccessfulProcess()
2222
{
2323
$context = (new RunProcessMessageHandler())(new RunProcessMessage(['ls'], cwd: __DIR__));
2424

25-
$this->assertSame(['ls'], $context->command);
25+
$this->assertSame(['ls'], $context->message->command);
2626
$this->assertSame(0, $context->exitCode);
2727
$this->assertStringContainsString(basename(__FILE__), $context->output);
2828
}
@@ -32,7 +32,7 @@ public function testRunFailedProcess()
3232
try {
3333
(new RunProcessMessageHandler())(new RunProcessMessage(['invalid']));
3434
} catch (RunProcessFailedException $e) {
35-
$this->assertSame(['invalid'], $e->context->command);
35+
$this->assertSame(['invalid'], $e->context->message->command);
3636
$this->assertSame('\\' === \DIRECTORY_SEPARATOR ? 1 : 127, $e->context->exitCode);
3737

3838
return;

0 commit comments

Comments
 (0)