Skip to content

Commit 1a44dc3

Browse files
[PhpUnitBridge] Kill the last concurrent process when it stales for more than 60s
1 parent 86ca4c7 commit 1a44dc3

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

Tests/ProcessTest.php

+9-7
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,11 @@ public function testInvalidCwd()
6666
$cmd->run();
6767
}
6868

69+
/**
70+
* @group transient-on-windows
71+
*/
6972
public function testThatProcessDoesNotThrowWarningDuringRun()
7073
{
71-
if ('\\' === \DIRECTORY_SEPARATOR) {
72-
$this->markTestSkipped('This test is transient on Windows');
73-
}
7474
@trigger_error('Test Error', \E_USER_NOTICE);
7575
$process = $this->getProcessForCode('sleep(3)');
7676
$process->run();
@@ -130,12 +130,11 @@ public function testStopWithTimeoutIsActuallyWorking()
130130
$this->assertLessThan(15, microtime(true) - $start);
131131
}
132132

133+
/**
134+
* @group transient-on-windows
135+
*/
133136
public function testWaitUntilSpecificOutput()
134137
{
135-
if ('\\' === \DIRECTORY_SEPARATOR) {
136-
$this->markTestIncomplete('This test is too transient on Windows, help wanted to improve it');
137-
}
138-
139138
$p = $this->getProcess([self::$phpBin, __DIR__.'/KillableProcessWithOutput.php']);
140139
$p->start();
141140

@@ -1538,6 +1537,9 @@ public function testEnvCaseInsensitiveOnWindows()
15381537
}
15391538
}
15401539

1540+
/**
1541+
* @group transient-on-windows
1542+
*/
15411543
public function testNotTerminableInputPipe()
15421544
{
15431545
$process = $this->getProcess('echo foo');

0 commit comments

Comments
 (0)