-
-
Notifications
You must be signed in to change notification settings - Fork 503
Add fastfony/webpack-vue-pack #1458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
|
Should be in https://github.com/symfony/recipes-contrib IMHO |
I'm not sure to understand why. It's a pack like webapp-pack which use only symfony packages. I understand that symfony/webapp-pack do the choice to use AssetMapper. Here, it's the choice to continue to use Webpack, which is not deprecated in the symfony ecosystem? |
|
From this repository README:
|
In order to try to be "official" recipes for Composer packages endorsed by the Symfony Core Team.
Head branch was pushed to by a user without write access
It doesn't say what are conditions for to be "endorsed by the Symfony Core Team". This PR is my purpose ;-) I see recipes not from Symfony repositories and contributed and maintain by people outside the core team. That's why I took the liberty of doing it. I think this recipe is very interesting to include in this repo because it makes it really easy for developers to build a web project with Webpack (and Vue). It could be added to the Symfony documentation: Using Composer: By not mentioning vue, we are not imposing the choice of AssetMapper or Webpack (ux-vue is compatible with both AssetMapper and Webpack). The extra step of adding recipes-contrib in Composer is a "difficult" step, IMHO. I am convinced that I am not the only one interested in this recipe. Unless the use of Webpack and creating SFC .vue files in a Symfony project are deprecated or no longer supported. Is this documented? Did I miss it? |
Being interested in the recipe does not mean it has to be in this repo vs recipes-contrib. |
|
Closing as explained, please consider reopening on recipes-contrib. |
Pull request was closed
|
This recipe (and the pack behind it) is almost the same of webapp : the difference is Webpack versus AssetMapper. This recipe interest is aliases and in recipes-contrib there aren't aliases. I don't understand that is explained because this recipe has no interest in recipes-contrib without aliases, so it's not an explanation for closing it 😞 Is offering an alternative to Why close this purpose of new alias for simply creating project with webapp-pack - asset mapper + webpack? I can understand the response rejecting Webpack, but it needs to be stated... documented and archived/abandoned related repositories! |
An other pack to install on top of the default Symfony skeleton, similar to symfony/webpack-pack but with Webpack instead of AssetMapper and able to compile .vue files.