Skip to content

Conversation

@neothone
Copy link

@neothone neothone commented Oct 9, 2025

Q A
License MIT
Doc issue/PR ...

An other pack to install on top of the default Symfony skeleton, similar to symfony/webpack-pack but with Webpack instead of AssetMapper and able to compile .vue files.

Copilot AI review requested due to automatic review settings October 9, 2025 15:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 9, 2025 15:28
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1458/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1458/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'fastfony/webapp-vue-pack:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@Kocal
Copy link
Member

Kocal commented Oct 9, 2025

Should be in https://github.com/symfony/recipes-contrib IMHO

@neothone
Copy link
Author

Should be in https://github.com/symfony/recipes-contrib IMHO

I'm not sure to understand why. It's a pack like webapp-pack which use only symfony packages.

I understand that symfony/webapp-pack do the choice to use AssetMapper. Here, it's the choice to continue to use Webpack, which is not deprecated in the symfony ecosystem?

@Kocal
Copy link
Member

Kocal commented Oct 10, 2025

From this repository README:

This repository contains "official" recipes for Composer packages endorsed by the Symfony Core Team. For contributed recipes, see the contrib repository.

In order to try to be "official" recipes for Composer packages endorsed by the Symfony Core Team.
auto-merge was automatically disabled October 10, 2025 08:13

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 10, 2025 08:13
@neothone
Copy link
Author

neothone commented Oct 10, 2025

From this repository README:

This repository contains "official" recipes for Composer packages endorsed by the Symfony Core Team. For contributed recipes, see the contrib repository.

It doesn't say what are conditions for to be "endorsed by the Symfony Core Team". This PR is my purpose ;-)

I see recipes not from Symfony repositories and contributed and maintain by people outside the core team. That's why I took the liberty of doing it.

I think this recipe is very interesting to include in this repo because it makes it really easy for developers to build a web project with Webpack (and Vue).

It could be added to the Symfony documentation:

Using Composer:

# run this if you are building a traditional web application with AssetMapper
composer create-project symfony/skeleton:"7.3.x" my_project_directory
cd my_project_directory
composer require webapp

# run this if you are building a traditional web application with Webpack
composer create-project symfony/skeleton:"7.3.x" my_project_directory
cd my_project_directory
composer require webapp-webpack

# run this if you are building a microservice, console application or API
composer create-project symfony/skeleton:"7.3.x" my_project_directory

By not mentioning vue, we are not imposing the choice of AssetMapper or Webpack (ux-vue is compatible with both AssetMapper and Webpack).

The extra step of adding recipes-contrib in Composer is a "difficult" step, IMHO.
Also, if you install webapp-pack, you must remove symfony/asset-mapper symfony/stimulus-bundle symfony/ux-turbo for then install webpack, ux-vue...

I am convinced that I am not the only one interested in this recipe.

Unless the use of Webpack and creating SFC .vue files in a Symfony project are deprecated or no longer supported. Is this documented? Did I miss it?

@stof
Copy link
Member

stof commented Oct 10, 2025

I am convinced that I am not the only one interested in this recipe.

Being interested in the recipe does not mean it has to be in this repo vs recipes-contrib.
Flex allows projects to disable the contrib recipes if they want only the "official" recipes that were vetted by the core team, but contrib recipes are enabled by default.

@chalasr
Copy link
Member

chalasr commented Oct 10, 2025

Closing as explained, please consider reopening on recipes-contrib.

@chalasr chalasr closed this Oct 10, 2025
auto-merge was automatically disabled October 10, 2025 08:48

Pull request was closed

@neothone
Copy link
Author

This recipe (and the pack behind it) is almost the same of webapp : the difference is Webpack versus AssetMapper.

This recipe interest is aliases and in recipes-contrib there aren't aliases.

I don't understand that is explained because this recipe has no interest in recipes-contrib without aliases, so it's not an explanation for closing it 😞

Is offering an alternative to compose require webapp with compose require webapp-webpack not a good idea?
Does this mean that we are abandoning Webpack and that starting a project with it is no longer recommended?

Why close this purpose of new alias for simply creating project with webapp-pack - asset mapper + webpack?

I can understand the response rejecting Webpack, but it needs to be stated... documented and archived/abandoned related repositories!

@neothone neothone deleted the main branch October 10, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants