Skip to content

Commit a61fa43

Browse files
committed
minor #20620 [Encore] [Frontend] Correct "Removes comments from CSS" comparison (Kocal)
This PR was merged into the 6.4 branch. Discussion ---------- [Encore] [Frontend] Correct "Removes comments from CSS" comparison Hey! Following internal discussions about Encore, I came across [this page](https://symfony.com/doc/6.4/frontend.html#using-php-twig) and found incorrect information, Encore can remove comments from CSS by configuring the `CssMinimizerPlugin`, included with Encore. On another note, I don't really understand the sentence `Can update 3rd party packages`. It looks like a comparaison between `importmap:require` and something that is not a Node.js package manager... right? isn't this comparison biased? Thanks! Commits ------- bed785d [Frontend] Correct "Removes comments from CSS" comparison
2 parents ecafe1d + bed785d commit a61fa43

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

frontend.rst

+6-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Supports Sass/Tailwind :ref:`yes <asset-mapper-tailwind>` yes
3535
Supports React, Vue, Svelte? yes :ref:`[1] <ux-note-1>` yes
3636
Supports TypeScript :ref:`yes <asset-mapper-ts>` yes
3737
Removes comments from JavaScript no :ref:`[2] <ux-note-2>` yes
38-
Removes comments from CSS no :ref:`[2] <ux-note-2>` no
38+
Removes comments from CSS no :ref:`[2] <ux-note-2>` yes :ref:`[4] <ux-note-4>`
3939
Versioned assets always optional
4040
Can update 3rd party packages yes no :ref:`[3] <ux-note-3>`
4141
================================ ================================== ==========
@@ -56,6 +56,10 @@ be executed by a browser.
5656

5757
**[3]** If you use ``npm``, there are update checkers available (e.g. ``npm-check``).
5858

59+
.. _ux-note-4:
60+
61+
**[4]** Comments from CSS code can be removed with `CssMinimizerPlugin`_, configurable with ``Encore.configureCssMinimizerPlugin()``.
62+
5963
.. _frontend-asset-mapper:
6064

6165
AssetMapper (Recommended)
@@ -153,3 +157,4 @@ Other Front-End Articles
153157
.. _`SensioLabs Minify Bundle`: https://github.com/sensiolabs/minify-bundle
154158
.. _`AssetMapper screencast series`: https://symfonycasts.com/screencast/asset-mapper
155159
.. _`API Platform screencast series`: https://symfonycasts.com/screencast/api-platform
160+
.. _`CssMinimizerPlugin`: https://webpack.js.org/plugins/css-minimizer-webpack-plugin

0 commit comments

Comments
 (0)