Skip to content

Commit 14de03a

Browse files
authored
Merge pull request #118 from syncpoint/fix/electron-builder-version
fix(build): align electron-builder with Electron 42 and remove version drift
2 parents e81a8cf + 03e4e1a commit 14de03a

4 files changed

Lines changed: 9 additions & 12 deletions

File tree

electron-builder.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,3 @@ snap:
5151
publish:
5252
- provider: github
5353
releaseType: release
54-
55-
electronVersion: 38.8.0

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@
6262
"react": "^18.0.0"
6363
},
6464
"serialize-javascript": "^7.0.5",
65-
"diff": "^9.0.0"
65+
"diff": "^9.0.0",
66+
"node-abi": "^4.31.0"
6667
},
6768
"dependencies": {
6869
"@mdi/js": "^7.0.96",

webpack.config.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
const path = require('path')
2-
const fs = require('fs')
32
const { spawn } = require('child_process')
43
const HtmlWebpackPlugin = require('html-webpack-plugin')
54
const webpack = require('webpack')
6-
const YAML = require('yaml')
75

8-
// Pick up Electron version [X.Y] from builder configuration:
6+
// Pick up Electron version [X.Y] from the installed electron package.
7+
// This is the single source of truth — electron-builder auto-detects the
8+
// same dependency, so the build target and the packaged runtime cannot drift.
99
const { rendererTarget, mainTarget, preloadTarget } = (() => {
10-
const file = fs.readFileSync('./electron-builder.yml', 'utf8')
11-
const configuration = YAML.parse(file)
12-
const version = configuration.electronVersion.match(/(\d+\.\d+)/)[0]
10+
const version = require('electron/package.json').version.match(/(\d+\.\d+)/)[0]
1311

1412
return {
1513
rendererTarget: 'electron' + version + '-renderer',

0 commit comments

Comments
 (0)