Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newhart must be zeroed #69

Open
testriscv opened this issue Jan 18, 2025 · 5 comments · May be fixed by #77
Open

newhart must be zeroed #69

testriscv opened this issue Jan 18, 2025 · 5 comments · May be fixed by #77

Comments

@testriscv
Copy link

testriscv commented Jan 18, 2025

hart_t *newhart must be zeroed

with
memset (newhart,0,sizeof(hart_t));
after
hart_t *newhart = malloc(sizeof(hart_t));

because sometimes the cpu starts with wrong settings causing exceptions.

@jserv
Copy link
Collaborator

jserv commented Jan 19, 2025

Can you submit a pull request to consolidate?

@testriscv
Copy link
Author

i'll try as soos as possible

@jserv
Copy link
Collaborator

jserv commented Mar 26, 2025

i'll try as soos as possible

@testriscv, are you ready to submit pull request(s)?

@EricccTaiwan EricccTaiwan linked a pull request Mar 31, 2025 that will close this issue
@EricccTaiwan
Copy link

EricccTaiwan commented Mar 31, 2025

Hi @testriscv,
I’ve submitted a PR #77 to address this issue, and I’d like to acknowledge you as a Co-author since you identified the problem and proposed the solution.
Would you mind sharing your preferred name and email for attribution?

@jserv
Copy link
Collaborator

jserv commented Apr 1, 2025

Would you mind sharing your preferred name and email for attribution?

Alternatively, use Reported-by @testriscv to maintain anonymity and traceability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants