Fix deference behavior on mixed subscript and arrow / dot operators #182
+75
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrXiao
reviewed
Mar 20, 2025
ChAoSUnItY
changed the title
jserv
reviewed
Mar 20, 2025
jserv
reviewed
Mar 20, 2025
jserv
reviewed
Mar 20, 2025
Previously, using subscription operator (literally "[]") with arrow operator (literally "->") or dot operator (literally ".") would cause incorrect dereference result due to inappropriate delayed dereference strategy. In this patch, by adding dereference instructin when encount- ered subscription operator and under correct circumstances fixes the issue.
ChAoSUnItY
changed the title
jserv
requested changes
Mar 20, 2025
jserv
reviewed
Mar 20, 2025
| @@ -1260,6 +1260,22 @@ void read_lvalue(lvalue_t *lvalue, | |||
| while (lex_peek(T_open_square, NULL) || lex_peek(T_arrow, NULL) || | |||
| lex_peek(T_dot, NULL)) { | |||
| if (lex_accept(T_open_square)) { | |||
| /* if subscripted member's is not yet resolved, deference to resolve | |||
There was a problem hiding this comment.
There should be a comma (,) appearing right after "e.g.". That is, e.g.,.
See https://www.scribbr.com/definitions/for-example-abbreviation/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Bito
This pull request fixes a double free error in the globals file and enhances type safety in the parser by changing variable types from int to bool. It also introduces new tests for dynamic data structures, focusing on mixed subscript and arrow/dot operators to improve code reliability and safety.Unit tests added: True
Estimated effort to review (1-5, lower is better): 2