Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textDocument/formatting is not supported #29

Closed
novusnota opened this issue Feb 26, 2024 · 3 comments
Closed

textDocument/formatting is not supported #29

novusnota opened this issue Feb 26, 2024 · 3 comments

Comments

@novusnota
Copy link
Member

Language server as per LSP documentation can support textDocument/formatting method, which is called in any LS clients (mainly in editors) whenever whole file formatting is needed.

At the moment, this plugin has formatting implemented as a VSCode-only feature and not a part of LSP specification, which results in failure to format Tact code when the language server of this plugin is used independently (i.e. here) — a message such as this is shown: "textDocument/formatting not supported for tact".

The solution would be to register formatting capabilities and handle the textDocument/formatting request.

Additionally, there are two similar methods specified in LSP, which may also be handled to further improve UX:

@logvik
Copy link
Member

logvik commented Feb 27, 2024

I assume that this part can be done within grants-and-bounties task. PR is welcome.

@novusnota
Copy link
Member Author

novusnota commented Feb 27, 2024

@logvik Good suggestion, will do!

UPD: Tried to do it, with no avail yet.

@logvik
Copy link
Member

logvik commented Jun 25, 2024

Resolved at #38

@logvik logvik closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants