Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AstPrimaryExpression #1290

Closed
verytactical opened this issue Jan 9, 2025 · 1 comment
Closed

Remove AstPrimaryExpression #1290

verytactical opened this issue Jan 9, 2025 · 1 comment
Assignees
@verytactical
Labels
kind: refactoring Improve code readability scope: ast AST (src/ast/*)
Milestone
v1.6.0

Comments

@verytactical
Copy link
Contributor

PrimaryExpression is a name of the rule in grammar, and shouldn't really matter in the rest of the compiler. Currently the fact this type exists already caused problems twice

  • when generating schema for AST, there is no way to makeVisitor over the Expression, because it unions PrimaryExpression non-algebraically
  • when adding AstLiteral there is no clear place to add it
@verytactical verytactical mentioned this issue Jan 9, 2025
Merged
4 tasks
@anton-trunov anton-trunov added kind: refactoring Improve code readability scope: ast AST (src/ast/*) labels Jan 15, 2025
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 15, 2025
@anton-trunov anton-trunov changed the title Remove AstPrimaryExpression Remove AstPrimaryExpression Jan 16, 2025
@anton-trunov
Copy link
Member

Fixed in #1324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verytactical verytactical

Labels
kind: refactoring Improve code readability scope: ast AST (src/ast/*)
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
2 participants
@anton-trunov @verytactical