Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forbid strings in ASM functions until we have proper grammar for it #1757

Closed
wants to merge 9 commits into from
Closed

fix: forbid strings in ASM functions until we have proper grammar for it #1757

wants to merge 9 commits into from

Conversation

i582
Copy link
Contributor

@i582 i582 commented Feb 10, 2025 •
edited
Loading

Issue

Closes #1030.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 requested a review from a team as a code owner February 10, 2025 08:23
@anton-trunov
Copy link
Member

Ok, let's solve it when we have a proper parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Malformed asm functions pass Tact compiler but fail during FunC compilation stage
2 participants
@i582 @anton-trunov