Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(stdlib): use assembly functions for throw* functions #1818

Closed
wants to merge 3 commits into from
Closed

refactor(stdlib): use assembly functions for throw* functions #1818

wants to merge 3 commits into from

Conversation

i582
Copy link
Contributor

@i582 i582 commented Feb 13, 2025

Issue

Closes #1813.
Closes #1814.
Closes #1815.
Closes #1816.

Checklist

  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 requested a review from a team as a code owner February 13, 2025 12:39
@i582 i582 requested a review from Shvandre February 13, 2025 12:40
@i582 i582 added this to the v1.6.0 milestone Feb 13, 2025
novusnota
novusnota requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the parameters :)

@i582 i582 changed the title refactor: use assembly functions for throw* functions refactor(stdlib): use assembly functions for throw* functions Feb 13, 2025
@i582
Copy link
Contributor Author

i582 commented Feb 13, 2025

It looks like we need to generate FunC code for them so that FunC can generate code for them correctly and use the flow analysis results for optimization:

telegram-cloud-photo-size-2-5291797066617579901-y

@i582 i582 removed this from the v1.6.0 milestone Feb 13, 2025
@i582 i582 closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novusnota novusnota novusnota requested changes

@Shvandre Shvandre Awaiting requested review from Shvandre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@i582 @novusnota