fix(connectRPC): add Connect-Protocol-Version header to gRPC requests (#3331)

Author: fengyuwusong

src/core/generator/proto/connect_rpc.rs

@@ -1,8 +1,28 @@
+use std::fmt::Display;
+
 use tailcall_valid::Valid;
 
 use crate::core::config::{Config, Grpc, Http, Resolver, ResolverSet};
 use crate::core::Transform;
 
+const HEADER_CONNECT_PROTOCOL_VERSION: &str = "Connect-Protocol-Version";
+
+enum ConnectProtocolVersion {
+    V1,
+}
+
+impl Display for ConnectProtocolVersion {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(
+            f,
+            "{}",
+            match self {
+                ConnectProtocolVersion::V1 => "1".to_string(),
+            }
+        )
+    }
+}
+
 pub struct ConnectRPC;
 
 impl Transform for ConnectRPC {
@@ -47,7 +67,12 @@ impl From<Grpc> for Http {
         let endpoint = parts[parts.len() - 1].to_string();
 
         let new_url = format!("{}/{}/{}", url, method, endpoint);
-        let headers = grpc.headers;
+        let mut headers = grpc.headers;
+        headers.push(crate::core::config::KeyValue {
+            key: HEADER_CONNECT_PROTOCOL_VERSION.to_string(),
+            value: ConnectProtocolVersion::V1.to_string(),
+        });
+
         let batch_key = grpc.batch_key;
         let dedupe = grpc.dedupe;
         let select = grpc.select;
@@ -136,6 +161,14 @@ mod tests {
                 .value,
             "bar".to_string()
         );
+        assert_eq!(
+            http.headers
+                .iter()
+                .find(|h| h.key == "Connect-Protocol-Version")
+                .unwrap()
+                .value,
+            "1".to_string()
+        );
         assert_eq!(http.body, Some(json!({})));
     }
 

tests/cli/snapshots/cli_spec__test__generator_spec__tests__cli__fixtures__generator__proto-connect-rpc.md.snap

@@ -1,5 +1,6 @@
 ---
 source: tests/cli/gen.rs
+assertion_line: 333
 expression: config.to_sdl()
 snapshot_kind: text
 ---
@@ -61,12 +62,12 @@ type News {
 }
 
 type Query {
-  GEN__news__NewsService__AddNews(news: GEN__news__NewsInput!): News @http(url: "http://localhost:50051/news.NewsService/AddNews", body: "{{.args.news}}", method: "POST")
-  GEN__news__NewsService__DeleteNews(newsId: Id!): Empty @http(url: "http://localhost:50051/news.NewsService/DeleteNews", body: "{{.args.newsId}}", method: "POST")
-  GEN__news__NewsService__EditNews(news: GEN__news__NewsInput!): News @http(url: "http://localhost:50051/news.NewsService/EditNews", body: "{{.args.news}}", method: "POST")
-  GEN__news__NewsService__GetAllNews: GEN__news__NewsList @http(url: "http://localhost:50051/news.NewsService/GetAllNews", body: {}, method: "POST")
-  GEN__news__NewsService__GetMultipleNews(multipleNewsId: GEN__news__MultipleNewsId!): GEN__news__NewsList @http(url: "http://localhost:50051/news.NewsService/GetMultipleNews", body: "{{.args.multipleNewsId}}", method: "POST")
-  GEN__news__NewsService__GetNews(newsId: Id!): News @http(url: "http://localhost:50051/news.NewsService/GetNews", body: "{{.args.newsId}}", method: "POST")
+  GEN__news__NewsService__AddNews(news: GEN__news__NewsInput!): News @http(url: "http://localhost:50051/news.NewsService/AddNews", body: "{{.args.news}}", headers: [{key: "Connect-Protocol-Version", value: "1"}], method: "POST")
+  GEN__news__NewsService__DeleteNews(newsId: Id!): Empty @http(url: "http://localhost:50051/news.NewsService/DeleteNews", body: "{{.args.newsId}}", headers: [{key: "Connect-Protocol-Version", value: "1"}], method: "POST")
+  GEN__news__NewsService__EditNews(news: GEN__news__NewsInput!): News @http(url: "http://localhost:50051/news.NewsService/EditNews", body: "{{.args.news}}", headers: [{key: "Connect-Protocol-Version", value: "1"}], method: "POST")
+  GEN__news__NewsService__GetAllNews: GEN__news__NewsList @http(url: "http://localhost:50051/news.NewsService/GetAllNews", body: {}, headers: [{key: "Connect-Protocol-Version", value: "1"}], method: "POST")
+  GEN__news__NewsService__GetMultipleNews(multipleNewsId: GEN__news__MultipleNewsId!): GEN__news__NewsList @http(url: "http://localhost:50051/news.NewsService/GetMultipleNews", body: "{{.args.multipleNewsId}}", headers: [{key: "Connect-Protocol-Version", value: "1"}], method: "POST")
+  GEN__news__NewsService__GetNews(newsId: Id!): News @http(url: "http://localhost:50051/news.NewsService/GetNews", body: "{{.args.newsId}}", headers: [{key: "Connect-Protocol-Version", value: "1"}], method: "POST")
   users: [User] @http(url: "http://jsonplaceholder.typicode.com/users")
 }