update view_modifiers#23
Closed
josh-thurston wants to merge 1 commit intotalkpython:masterfrom
josh-thurston:master
Closed
update view_modifiers#23josh-thurston wants to merge 1 commit intotalkpython:masterfrom josh-thurston:master
josh-thurston wants to merge 1 commit intotalkpython:masterfrom
josh-thurston:master
Conversation
Based on email Michael sent me June 2020. Had to change the response function.
Member
|
Thanks @josh-thurston ! Remind me about the details of the change you're after there? Also, why |
|
Dang, dead silence. I wish @josh-thurston would've reminded @mikeckennedy about the purposed change. I'm curious because I have had no problem with the way it is now and I love this design pattern. I have used it in multiple flask projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on email Michael sent me June 2020. Had to change the response function.