better internal error messages

Author: tancred423

src/service/MaintenanceSenderService.ts

@@ -8,7 +8,6 @@ import { GlobalClient } from "../index.ts";
 import { Setup } from "../database/schema/setups.ts";
 import { SetupsRepository } from "../database/repository/SetupsRepository.ts";
 import { DiscordEmbedService } from "./DiscordEmbedService.ts";
-import { LodestoneServiceUnavailableError } from "../naagostone/error/LodestoneServiceUnavailableError.ts";
 import * as log from "@std/log";
 
 const saveLodestoneNews = Deno.env.get("SAVE_LODESTONE_NEWS") === "true";
@@ -20,9 +19,7 @@ export class MaintenanceSenderService {
     try {
       latestMaintenances = await NaagostoneApiService.fetchLatest10Maintenances();
     } catch (error: unknown) {
-      if (error instanceof LodestoneServiceUnavailableError) {
-        log.error(`[MAINTENANCES] Lodestone service is unavailable: ${error.message}`);
-      } else if (error instanceof Error) {
+      if (error instanceof Error) {
         log.error(`[MAINTENANCES] Fetching latest maintenances was NOT successful: ${error.message}`);
       }
       return 0;

src/service/NoticeSenderService.ts

@@ -8,7 +8,6 @@ import { GlobalClient } from "../index.ts";
 import { Setup } from "../database/schema/setups.ts";
 import { SetupsRepository } from "../database/repository/SetupsRepository.ts";
 import { DiscordEmbedService } from "./DiscordEmbedService.ts";
-import { LodestoneServiceUnavailableError } from "../naagostone/error/LodestoneServiceUnavailableError.ts";
 import * as log from "@std/log";
 
 const saveLodestoneNews = Deno.env.get("SAVE_LODESTONE_NEWS") === "true";
@@ -20,9 +19,7 @@ export class NoticeSenderService {
     try {
       latestNotices = await NaagostoneApiService.fetchLatest10Notices();
     } catch (error: unknown) {
-      if (error instanceof LodestoneServiceUnavailableError) {
-        log.error(`[NOTICES] Lodestone service is unavailable: ${error.message}`);
-      } else if (error instanceof Error) {
+      if (error instanceof Error) {
         log.error(`[NOTICES] Fetching latest notices was NOT successful: ${error.message}`);
       }
       return 0;

src/service/StatusSenderService.ts

@@ -9,7 +9,6 @@ import { GlobalClient } from "../index.ts";
 import { Setup } from "../database/schema/setups.ts";
 import { SetupsRepository } from "../database/repository/SetupsRepository.ts";
 import { DiscordEmbedService } from "./DiscordEmbedService.ts";
-import { LodestoneServiceUnavailableError } from "../naagostone/error/LodestoneServiceUnavailableError.ts";
 
 const saveLodestoneNews = Deno.env.get("SAVE_LODESTONE_NEWS") === "true";
 const sendLodestoneNews = Deno.env.get("SEND_LODESTONE_NEWS") === "true";
@@ -20,9 +19,7 @@ export default class StatusSenderService {
     try {
       latestStatuses = await NaagostoneApiService.fetchLatest10Statuses();
     } catch (error: unknown) {
-      if (error instanceof LodestoneServiceUnavailableError) {
-        log.error(`[STATUS] Lodestone service is unavailable: ${error.message}`);
-      } else if (error instanceof Error) {
+      if (error instanceof Error) {
         log.error(`[STATUS] Fetching latest statuses was NOT successful: ${error.message}`);
       }
       return 0;

src/service/TopicSenderService.ts

@@ -9,7 +9,6 @@ import { Setup } from "../database/schema/setups.ts";
 import { TopicData } from "../database/schema/lodestone-news.ts";
 import { SetupsRepository } from "../database/repository/SetupsRepository.ts";
 import { DiscordEmbedService } from "./DiscordEmbedService.ts";
-import { LodestoneServiceUnavailableError } from "../naagostone/error/LodestoneServiceUnavailableError.ts";
 
 const saveLodestoneNews = Deno.env.get("SAVE_LODESTONE_NEWS") === "true";
 const sendLodestoneNews = Deno.env.get("SEND_LODESTONE_NEWS") === "true";
@@ -20,9 +19,7 @@ export class TopicSenderService {
     try {
       latestTopics = await NaagostoneApiService.fetchLatest10Topics();
     } catch (error: unknown) {
-      if (error instanceof LodestoneServiceUnavailableError) {
-        log.error(`[TOPICS] Lodestone service is unavailable: ${error.message}`);
-      } else if (error instanceof Error) {
+      if (error instanceof Error) {
         log.error(`[TOPICS] Fetching latest topics was NOT successful: ${error.message}`);
       }
       return 0;

src/service/UpdateSenderService.ts

@@ -7,7 +7,6 @@ import { GlobalClient } from "../index.ts";
 import { Setup } from "../database/schema/setups.ts";
 import { SetupsRepository } from "../database/repository/SetupsRepository.ts";
 import { DiscordEmbedService } from "./DiscordEmbedService.ts";
-import { LodestoneServiceUnavailableError } from "../naagostone/error/LodestoneServiceUnavailableError.ts";
 import * as log from "@std/log";
 
 const saveLodestoneNews = Deno.env.get("SAVE_LODESTONE_NEWS") === "true";
@@ -19,9 +18,7 @@ export class UpdateSenderService {
     try {
       latestUpdates = await NaagostoneApiService.fetchLatest10Updates();
     } catch (error: unknown) {
-      if (error instanceof LodestoneServiceUnavailableError) {
-        log.error(`[UPDATES] Lodestone service is unavailable: ${error.message}`);
-      } else if (error instanceof Error) {
+      if (error instanceof Error) {
         log.error(`[UPDATES] Fetching latest updates was NOT successful: ${error.message}`);
       }
       return 0;