Skip to content

Conversation

@legendword
Copy link
Contributor

@legendword legendword commented Aug 26, 2023

Changes

  • When a user clicks "Next" in a multi-content unit, show unit completion screen.
  • When a user clicks "Finish" which is shown for the last page in a multi-content unit, show program completion screen (if in TYDE mode).

Screenshot

  • To be added.

Issue Linkage

Closes #1335

PR Dependency

Depends on: #1325

Automated Testing

  • N/A

@cypress
Copy link

cypress bot commented Aug 26, 2023

93 failed tests on run #4065 ↗︎

93 0 0 7 Flakiness 0

Details:

Fix unit completion Continue button functionality
Project: tapestry-wp Commit: 28e7827a2a
Status: Failed Duration: 07:27 💡
Started: Sep 11, 2023 11:35 PM Ended: Sep 11, 2023 11:42 PM
Failed  lightbox/activity.spec.js • 13 failed tests

View Output Video

Test Artifacts
Activity > should be able to complete drag and drop answer with items with background image and text Output Screenshots Video
Activity > should be able to move items to different buckets in all directions in drag and drop answer mode Output Screenshots Video
Activity > should be able to complete drag and drop answer with items with no background image Output Screenshots Video
Activity > should be able to complete with a checkbox answer Output Screenshots Video
Activity > should be able to complete with a radio answer Output Screenshots Video
Activity > should be able to switch between questions in an activity Output Screenshots Video
Activity > should be able to edit single-line text already answered question Output Screenshots Video
Activity > should be able to complete an activity with a text-based answer Output Screenshots Video
Activity > should be able to complete an activity with an audio-based answer Output Screenshots Video
Activity > should be able to complete with a list-based answer Output Screenshots Video
The first 10 failed tests are shown, see all 13 tests in Cypress Cloud.
Failed  import-export.spec.js • 14 failed tests

View Output Video

Test Artifacts
Export > should be able to export a Tapestry Output Screenshots Video
Export > should be able to export a Tapestry as a zip file Output Screenshots Video
Export > should be able to export a Tapestry as a zip file and WordPress posts Output Screenshots Video
Export > should be able to export a Tapestry with warnings Output Screenshots Video
Import > should be able to import a Tapestry using file input Output Screenshots Video
Import > should be able to import a Tapestry using old export file input Output Screenshots Video
Import > should not be able to import a file that is not zip or json Output Screenshots Video
Import > should not be able to import a zip with no tapestry.json Output Screenshots Video
Import > should not be able to import a zip where tapestry.json is not valid JSON Output Screenshots Video
Import > should not be able to import a zip where tapestry.json is missing required fields Output Screenshots Video
The first 10 failed tests are shown, see all 14 tests in Cypress Cloud.
Failed  node-authoring.spec.js • 11 failed tests

View Output Video

Test Artifacts
Node Authoring > should be able to add a root node using the node modal Output Screenshots Video
Node Authoring > should not show error when adding node with long description Output Screenshots Video
Node Authoring > should be able to delete a leaf node Output Screenshots Video
Node Authoring > should not be able to delete a non-leaf node Output Screenshots Video
Node Authoring > should render warning and be able to delete node if node has draft child from another user Output Screenshots Video
Node Authoring > Non-empty > should be able to add a child node using the node modal Output Screenshots Video
Node Authoring > Non-empty > should be able to edit a node's title using the node modal Output Screenshots Video
Node Authoring > Non-empty > Should show an error and not create a node if an mp4 URL is invalid Output Screenshots Video
Node Authoring > Non-empty > Should close modal with a good video url even after an error has occurred Output Screenshots Video
Node Authoring > Non-empty > should display API errors in the modal if they occur during submission Output Screenshots Video
The first 10 failed tests are shown, see all 11 tests in Cypress Cloud.
Failed  lightbox/multicontent.spec.js • 9 failed tests

View Output Video

Test Artifacts
Multi-content > In-place > should be able to add/edit/delete multi-content child node in-place Output Screenshots Video
Multi-content > Accordion > should be able to make a node an accordion Output Screenshots Video
Multi-content > Accordion > should be able to add child rows to an accordion Output Screenshots Video
Multi-content > Accordion > should be able to lock accordion rows and progress through them Output Screenshots Video
Multi-content > Accordion > should be able to reorder accordion rows Output Screenshots Video
Multi-content > Accordion > should be able to add child nodes to accordion rows and have them appear as subaccordions Output Screenshots Video
Multi-content > Accordion > should not be able to add a node to subaccordion row if accordion row is not an accordion Output Screenshots Video
Multi-content > Accordion > should not show descendants to subscriber Output Screenshots Video
Multi-content > Page > should render text content, more content and hide locked content Output Screenshots Video
Failed  lightbox/video.spec.js • 8 failed tests

View Output Video

Test Artifacts
Video > adding a youtube video should also set a thumbnail Output Screenshots Video
Video > should be able to add a video node via url Output Screenshots Video
Video > should be able to add a video node via youtube Output Screenshots Video
Video > should automatically update video url when the current url becomes unavailable Output Screenshots Video
Video > should be able to add a video node via Kaltura and use regular player Output Screenshots Video
Video > should be able to add a video node via Kaltura and use Kaltura player Output Screenshots Video
Video > adding a kaltura video should also set a thumbnail Output Screenshots Video
Video > should be able to add a caption to a video Output Screenshots Video

The first 5 failed specs are shown, see all 22 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@legendword legendword changed the base branch from tyde-with-kaltura-fixes to 1324-circle-view-onboarding September 25, 2023 00:08
@legendword legendword marked this pull request as ready for review September 25, 2023 00:08
@legendword legendword added the needs final review Has been tested and reviewed once and needs another code review to become ready for merge label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs final review Has been tested and reviewed once and needs another code review to become ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants