Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember example link broken #2235

Closed
flashdesignory opened this issue Jan 17, 2024 · 6 comments · Fixed by #2238
Closed

Ember example link broken #2235

flashdesignory opened this issue Jan 17, 2024 · 6 comments · Fixed by #2238

Comments

@flashdesignory
Copy link
Collaborator

This link: https://todomvc.com/examples/emberjs/ does not seem to be functional.
@NullVoxPopuli - are you able to take a look?

@flashdesignory
Copy link
Collaborator Author

The new additions / updates that I added are pointing to a 'dist' folder. I think it's ok to do the same here, which would eliminate to copy files to the root.

@NullVoxPopuli
Copy link
Contributor

what command is supposed to generate files for that?

It looks like the /examples/emberjs/ URL Prefix just needs added -- I can do that if there is a way to test locally?

@flashdesignory
Copy link
Collaborator Author

flashdesignory commented Jan 17, 2024

I don't think you'll need a command, rather the index.html page could link to 'examples/emberjs/todomvc/dist/', without the need to have a copy of the dist folder outside of the todomvc folder.

Is there a way in Ember to set a base url or a root url to prefix examples/emberjs/ ?
Maybe in a config file?

The app should be functional if you run the whole todomvc site locally.
Just make sure you're using the right version of node for todomvc and then it should be just npm run gulp serve and you should be able to go to the ember app locally.

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Jan 17, 2024

page could link to 'examples/emberjs/todomvc/dist/',

Ending with dist is curious -- how is this repo built? is it GH pages?

I suppose ending with dist makes sense, if it's just the main branch + GH pages

@flashdesignory
Copy link
Collaborator Author

using a dist folder is just for consistency. Most frameworks that use a build step point to a dist folder (or something similar) and don't build in the root of the project. It avoids the step to manually move the build files to the root directory of the ember app.

@NullVoxPopuli
Copy link
Contributor

Oh that's not what i meant, i meant the revealing of 'dist' in the URL. But since it's basically just the branch that is 'the repos dist', it makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants