Best way to access fn_name from middleware after 6.3.2?

[victorfrancax1]

Bumped to 6.3.2 and got ImportError: cannot import name 'task_context' from 'streaq.types'. I was using the ContextVars from #18 to get the function name inside an observability middleware.

TaskDepends/WorkerDepends looks like the new way to do this, but as far as I can tell it only works for task functions — task.__name__ in middleware is always "_fn" because of the internal closure. Is there a recommended way to get fn_name in a middleware now?

[Graeme22]

Dependencies should work in middleware, is that not working for you?

[Graeme22]

Actually good catch, looks like I broke dependency injection in middleware... Oops! You can do something like:

@worker.middleware
def print_context(task):
    async def wrapper(*args, **kwargs):
        if ctx := next(
            (k for k in kwargs.values() if isinstance(k, TaskContext)), None
        ):
            print(ctx)
        return await task(*args, **kwargs)

    return wrapper

but this requires that ctx be in the task's own definition. I may be able to come up with a half-way solution between the new approach and the context vars.

[Graeme22]

Though it should be noted importing the context var directly was never the supported pattern even before

[victorfrancax1]

Makes sense on the unsupported import. What we're really after is the middleware equivalent of TaskDepends - a way to get fn_name (and ideally task_id) in a cross-cutting observability middleware without requiring every task to opt into TaskDepends. Is that what you have in mind for the halfway solution?

[Graeme22]

Yes, been playing around with a couple variations