How to apply tinctures to all tests?

[Yutsuten]

This example in the documentation is awesome:

def time_request(stage):
    t0 = time.time()
    yield
    t1 = time.time()
    logger.info("Request for stage %s took %s", stage, t1 - t0)

# test_stuff.tavern.yaml
tinctures:
  - function: package.helpers:time_request

But I want to apply this to all tests and get all requests performance measured, so instead of adding these two lines of code to every single test, I'd like to use the including external files feature. I created an yaml file like this:

# include_tinctures.yaml
tinctures:
  - function: package.helpers:time_request

Then added this to pytest.ini:

[pytest]
tavern-global-cfg =
    include_tinctures.yaml

This should work like if we had this in every test, right?

includes:
  - !include include_tinctures.yaml

But I'm unable to make it work. Am I missing anything? Being able to do so would be awesome, tavern would become a performance tester too.

Thank you for the awesome tool by the way!!

[michaelboulton]

The tinctures currently are only applicable to a test/stage and aren't read from external files, you would have to put the lines in every test currently. They were intended as more of something you could do on some particular stages of a test instead of something like the hooks which do run on every request and response

Just a couple of idea if I do get around to it

I'm not sure how hard this would be to implement, I think its just adding it to a list of 'global' tinctures when loading from the global config

tavern/tavern/_core/pytest/util.py

Lines 164 to 173 in 4c9c87f

	global_cfg = TestConfig(
	variables=variables,
	strict=_load_global_strictness(pytest_config),
	follow_redirects=_load_global_follow_redirects(pytest_config),
	tavern_internal=TavernInternalConfig(
	pytest_hook_caller=pytest_config.hook,
	backends=_load_global_backends(pytest_config),
	),
	stages=global_cfg_dict.get("stages", []),
	)

and passing that all the way through to

tavern/tavern/_core/run.py

Line 320 in 77b04a1

tinctures = get_stage_tinctures(stage, self.test_spec)

. Or adding it to the schema here

tavern/tavern/_core/schema/tests.jsonschema.yaml

Lines 43 to 65 in 77b04a1

	included_file:
	type: object
	additionalProperties: false
	properties:
	name:
	type: string
	description: Name for this included file
	description:
	type: string
	description: Extra description for included file
	variables:
	type: object
	description: Variables to use in tests
	stages:
	type: array
	description: Stages to reference from tests
	items:
	$ref: "#/definitions/stage"

and loading tinctures from the stage config as well.