Skip to content

Commit e37968d

Browse files
committed
fix(versioncheck): drop VersionPolicy for chains with no trackable image
Nine chains publish no public, version-tagged container image, so every versioncheck run logged them as permanent 404/403/auth ERRORs and the ChainVersionCatalog reconciler churned on unreachable registries: cronos, telos, fantom, wemix, shibarium — no official/public registry bittorrent, sonic, zircuit, moca — source-build or private only VersionProvider is an optional interface by design; dropping VersionPolicy from these adapters removes them from version tracking cleanly. The catalog controller already handles non-implementers gracefully (sets the VersionProviderNotImplemented condition). Pinned default images in versions_gen.go are untouched — nodes still deploy on the manual pin. Context: reconciled this against the moved-repo registry survey, where these nine kept returning 404/403 with no working replacement (unlike morph and dogecoin, which relocated). Confirmed via a full versioncheck run that all nine now drop out of the report while cronos-zkevm and the rest stay. Build, adapter and controller tests green. Spent ~1.5h verifying each repo had no public image before excluding it.
1 parent d6345d5 commit e37968d

9 files changed

Lines changed: 0 additions & 72 deletions

File tree

internal/adapters/bittorrent.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,6 @@ func (a *bittorrentAdapter) DefaultResources() ResourceDefaults {
8181
}
8282
}
8383

84-
func (a *bittorrentAdapter) VersionPolicy() ChainVersionPolicy {
85-
return ChainVersionPolicy{
86-
Registry: "docker.io",
87-
Repository: "bttcprotocol/bttc",
88-
TagPattern: `^v\d+\.\d+\.\d+$`,
89-
}
90-
}
91-
9284
// --------------------------------------------------------------------------
9385
// Config
9486
// --------------------------------------------------------------------------

internal/adapters/cronos.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,6 @@ func (a *cronosAdapter) DefaultResources() ResourceDefaults {
8181
}
8282
}
8383

84-
func (a *cronosAdapter) VersionPolicy() ChainVersionPolicy {
85-
return ChainVersionPolicy{
86-
Registry: "docker.io",
87-
Repository: "crypto-org-chain/cronos",
88-
TagPattern: `^v\d+\.\d+\.\d+$`,
89-
}
90-
}
91-
9284
// --------------------------------------------------------------------------
9385
// Config
9486
// --------------------------------------------------------------------------

internal/adapters/fantom.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,6 @@ func (a *fantomAdapter) DefaultResources() ResourceDefaults {
100100
}
101101
}
102102

103-
func (a *fantomAdapter) VersionPolicy() ChainVersionPolicy {
104-
return ChainVersionPolicy{
105-
Registry: "docker.io",
106-
Repository: "fantomfoundation/go-opera",
107-
TagPattern: `^v\d+\.\d+\.\d+`,
108-
}
109-
}
110-
111103
// --------------------------------------------------------------------------
112104
// Config (static)
113105
// --------------------------------------------------------------------------

internal/adapters/moca.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,6 @@ func (a *mocaAdapter) DefaultResources() ResourceDefaults {
163163
}
164164
}
165165

166-
func (a *mocaAdapter) VersionPolicy() ChainVersionPolicy {
167-
return ChainVersionPolicy{
168-
Registry: "docker.io",
169-
Repository: "moca-network/moca",
170-
TagPattern: `^v\d+\.\d+\.\d+$`,
171-
}
172-
}
173-
174166
// --------------------------------------------------------------------------
175167
// Config
176168
// --------------------------------------------------------------------------

internal/adapters/shibarium.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,6 @@ func (a *shibariumAdapter) DefaultResources() ResourceDefaults {
8282
}
8383
}
8484

85-
func (a *shibariumAdapter) VersionPolicy() ChainVersionPolicy {
86-
return ChainVersionPolicy{
87-
Registry: "docker.io",
88-
Repository: "shibaone/bor",
89-
TagPattern: `^v\d+\.\d+\.\d+`,
90-
}
91-
}
92-
9385
// --------------------------------------------------------------------------
9486
// Config
9587
// --------------------------------------------------------------------------

internal/adapters/sonic.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,6 @@ func (a *sonicAdapter) DefaultResources() ResourceDefaults {
8888
}
8989
}
9090

91-
func (a *sonicAdapter) VersionPolicy() ChainVersionPolicy {
92-
return ChainVersionPolicy{
93-
Registry: "ghcr.io",
94-
Repository: "0xsoniclabs/sonic",
95-
TagPattern: `^v\d+\.\d+\.\d+$`,
96-
}
97-
}
98-
9991
// --------------------------------------------------------------------------
10092
// Config
10193
// --------------------------------------------------------------------------

internal/adapters/telos.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,14 +84,6 @@ func (a *telosAdapter) DefaultResources() ResourceDefaults {
8484
}
8585
}
8686

87-
func (a *telosAdapter) VersionPolicy() ChainVersionPolicy {
88-
return ChainVersionPolicy{
89-
Registry: "docker.io",
90-
Repository: "telosnetwork/telos-evm-rpc",
91-
TagPattern: `^v\d+\.\d+\.\d+$`,
92-
}
93-
}
94-
9587
// --------------------------------------------------------------------------
9688
// Config
9789
// --------------------------------------------------------------------------

internal/adapters/wemix.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,14 +84,6 @@ func (a *wemixAdapter) DefaultResources() ResourceDefaults {
8484
}
8585
}
8686

87-
func (a *wemixAdapter) VersionPolicy() ChainVersionPolicy {
88-
return ChainVersionPolicy{
89-
Registry: "docker.io",
90-
Repository: "wemixnetwork/wemix",
91-
TagPattern: `^v\d+\.\d+\.\d+$`,
92-
}
93-
}
94-
9587
// --------------------------------------------------------------------------
9688
// Config
9789
// --------------------------------------------------------------------------

internal/adapters/zircuit.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,6 @@ func (a *zircuitAdapter) DefaultResources() ResourceDefaults {
7373
}
7474
}
7575

76-
func (a *zircuitAdapter) VersionPolicy() ChainVersionPolicy {
77-
return ChainVersionPolicy{
78-
Registry: "ghcr.io",
79-
Repository: "zircuit-labs/l2-geth-public",
80-
TagPattern: `^v\d+\.\d+\.\d+$`,
81-
}
82-
}
83-
8476
func (a *zircuitAdapter) ContainerPorts(_ chainsv1alpha2.ChainInstanceSpec) []corev1.ContainerPort {
8577
return append(evmPorts(30303), corev1.ContainerPort{Name: "metrics", ContainerPort: 6060, Protocol: corev1.ProtocolTCP})
8678
}

0 commit comments

Comments
 (0)