Editorial: Reorder some TypedArray AOs to support top-down readability and future refactoring #3632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Jun 27, 2025
linusg
approved these changes
Jun 28, 2025
bakkot
reviewed
Jun 30, 2025
Member
|
LGTM once the assert is fixed. |
gibson042
force-pushed
the
3629-typedarray-ao-ordering
branch
from
706c645 to
863c536
Compare
bakkot
approved these changes
Jun 30, 2025
bakkot
added
the
ready to merge
…TypedArray (tc39#3632) The new [serendipitously alphabetical] ordering makes more obvious how SetTypedArrayFromTypedArray is a specialized adaptation of SetTypedArrayFromArrayLike when viewing the spec in top-to-bottom order.
ljharb
force-pushed
the
3629-typedarray-ao-ordering
branch
from
863c536 to
60c4df0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #3629 as requested at #3629 (comment) , starting with AO reordering because internal movement is a big cause of avoidable merge conflicts.