-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Editorial: Reduce redundant expressions in spec #3726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The rendered spec for this PR is available at https://tc39.es/ecma262/pr/3726. |
|
I disagree that these should generally be removed. While they may not make a technical difference, they help making the spec text easier to read; especially the adverbs have a meaning that convey an intention that would be otherwise be lost. |
|
The reason I’m proposing this PR is to ensure that the same expression/step/condition has the same form. If you believe that the meaning is not preserved in the merged forms above, it would be helpful to suggest a consistent format for that expression/step/condition. Also, regarding the adverbs you mentioned, I want to make a reminder that those forms are used max. 3 times throughout the entire spec. "also" and "already" do not add any additional meaning, and since there's already a "prepend" step corrensponding to "append" step, "the end of" is redundant in this context. |
michaelficarra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all seem like improvements to me.
|
To me, "does not already have x" implies "… but will now get x", which makes sense in those precondition-assertions. But sure, these few occurrences are not worth arguing over. |
|
For the I don't like removing the "already"s. The technical meaning is the same either way but, like @bergus, I find it clearer and more natural to include the word in those cases. Unfortunately this is strictly a matter of English prose-writing, which is an aesthetic judgement, but nevertheless this is my opinion. (The one "also" is in an awkward sentence anyway and so I am fine with dropping that particular instance.) The removal of "to the end of" and changes from "described" to "specified" seem good. |
|
Thanks for the feedback. To summarize, should I submit a PR that wraps the tags around the whole expression and keeps 'already' as is? |
|
@jungwngkim Please update this PR in that way. |
This PR reduces the following redundant expressions in spec.
For each cases, the line below is merged with above one.
The merging is based on the number of each cases. Smaller cases are merged to larger ones.
For reference, the number of line diff is 46 = 39 + 2 + 1 + 3 + 1.