Skip to content

Conversation

@jungwngkim
Copy link
Contributor

This PR implements points discussed in issue #3648

Although I've tried to replace every occurrence of 'otherwise' with 'else' in the algorithm steps, there were 16 cases where simply replacing with 'else' lead to awkward sentence. I listed them below.

$ grep "1\. .* otherwise" spec.html -n
(...) the host is a web browser or otherwise supports <emu-xref> # 11 cases
(...) if _Desc_ has that field, or to the attribute's <emu-xref>default value</emu-xref> otherwise. # 4 cases
NOTE: (...) unless specified otherwise. # 1 case

1. If _number_ is not a Number, return *false*.
1. If _number_ is *NaN*, return *true*.
1. Otherwise, return *false*.
1. Else, return *false*.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely we can just say Return *false*. here.

Suggested change
1. Else, return *false*.
1. Return *false*.

@michaelficarra
Copy link
Member

@tc39/ecma262-editors For the single-line if/else where both branches return, do we want to just split them up into two steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants